Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2852183002: Delete the tracing service (Closed)

Created:
3 years, 7 months ago by chiniforooshan
Modified:
3 years, 7 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, kalyank, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the tracing service This tracing service is not used by any one, AFAIK, and I am creating a new tracing service that is going to replace the tracing controller that currently exists in content/browser/tracing. To get an idea of the new service, please take a look at the prototype: https://codereview.chromium.org/2833873003/ BUG=640235 Review-Url: https://codereview.chromium.org/2852183002 Cr-Commit-Position: refs/heads/master@{#468684} Committed: https://chromium.googlesource.com/chromium/src/+/50510ac8fcc50e132c27edbb80d759cec829e47a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1278 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/window_manager_application.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/mus/window_manager_application.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/app/mash/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/app/mash/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/mash/embedded_services.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/filesystem/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/filesystem/file_system_app.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/font_service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/font_service/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/font_service/font_service_app.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/leveldb/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/leveldb/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/leveldb/leveldb_app.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mash/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/browser/browser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/browser/browser.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M mash/catalog_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/catalog_viewer/catalog_viewer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M mash/example/views_examples/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/views_examples/views_examples.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/quick_launch/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/quick_launch/quick_launch.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M mash/task_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/task_viewer/task_viewer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M mash/webtest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/webtest/webtest.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/webtest/webtest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/file/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/file/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M services/service_manager/service_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/service_manager/standalone/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M services/service_manager/standalone/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/standalone/context.h View 2 chunks +0 lines, -4 lines 0 comments Download
M services/service_manager/standalone/context.cc View 3 chunks +0 lines, -51 lines 0 comments Download
D services/service_manager/standalone/tracer.h View 1 chunk +0 lines, -98 lines 0 comments Download
D services/service_manager/standalone/tracer.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D services/tracing/BUILD.gn View 1 chunk +0 lines, -41 lines 0 comments Download
D services/tracing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D services/tracing/data_sink.h View 1 chunk +0 lines, -31 lines 0 comments Download
D services/tracing/data_sink.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D services/tracing/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D services/tracing/manifest.json View 1 chunk +0 lines, -18 lines 0 comments Download
D services/tracing/public/cpp/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D services/tracing/public/cpp/provider.h View 1 chunk +0 lines, -62 lines 0 comments Download
D services/tracing/public/cpp/provider.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D services/tracing/public/cpp/switches.h View 1 chunk +0 lines, -24 lines 0 comments Download
D services/tracing/public/cpp/switches.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D services/tracing/public/interfaces/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D services/tracing/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/tracing/public/interfaces/constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D services/tracing/public/interfaces/tracing.mojom View 1 chunk +0 lines, -66 lines 0 comments Download
D services/tracing/recorder.h View 1 chunk +0 lines, -41 lines 0 comments Download
D services/tracing/recorder.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D services/tracing/service.h View 1 chunk +0 lines, -95 lines 0 comments Download
D services/tracing/service.cc View 1 chunk +0 lines, -190 lines 0 comments Download
M services/ui/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M services/ui/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/clipboard/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/service.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
chiniforooshan
Elliot: for //components and //services/tracing Tom: for the two .mojom files Scott: for the rest ...
3 years, 7 months ago (2017-05-01 21:50:23 UTC) #1
chiniforooshan
oops, forgot to actually add reviewers. PTAL; thanks.
3 years, 7 months ago (2017-05-01 21:53:52 UTC) #5
Tom Sepez
RS LGTM on deleting .mojom files.
3 years, 7 months ago (2017-05-01 21:57:32 UTC) #6
Elliot Glaysher
lgtm and good riddance. thank you for doing this and good luck with the replacement.
3 years, 7 months ago (2017-05-01 21:59:30 UTC) #7
sky
LGTM
3 years, 7 months ago (2017-05-01 23:37:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852183002/1
3 years, 7 months ago (2017-05-02 14:21:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/425275)
3 years, 7 months ago (2017-05-02 14:33:04 UTC) #14
chiniforooshan
+Ken for //services/tracing (thought an lgtm from erg@ would cover this, but it won't). Thank ...
3 years, 7 months ago (2017-05-02 14:40:15 UTC) #16
Ken Rockot(use gerrit already)
On 2017/05/02 at 14:40:15, chiniforooshan wrote: > +Ken for //services/tracing (thought an lgtm from erg@ ...
3 years, 7 months ago (2017-05-02 16:49:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852183002/1
3 years, 7 months ago (2017-05-02 16:51:23 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:58:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50510ac8fcc50e132c27edbb80d7...

Powered by Google App Engine
This is Rietveld 408576698