Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2852143002: Add instructions for the Closure externs generator (Closed)

Created:
3 years, 7 months ago by michaelpg
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add instructions for the Closure externs generator Generated externs instruct maintainers to reference this doc to regenerate them, so add the expected instructions here. R=dbeam@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2852143002 Cr-Commit-Position: refs/heads/master@{#468487} Committed: https://chromium.googlesource.com/chromium/src/+/c1e2d1ed8a403ce0e350aebadd12e0c38102e33d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M docs/closure_compilation.md View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
michaelpg
PTAL.
3 years, 7 months ago (2017-05-01 19:57:20 UTC) #1
Dan Beam
if only we had a presubmit check to verify that when an idl/json schema was ...
3 years, 7 months ago (2017-05-01 20:38:38 UTC) #2
Devlin
Kinda like this? https://chromium.googlesource.com/chromium/src/+/de4c4327d2096b6d686b80a4cf4847ae9cc8f978/extensions/common/api/PRESUBMIT.py#38 It mostly stalled out because we don't have separate externs for ...
3 years, 7 months ago (2017-05-01 20:42:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852143002/1
3 years, 7 months ago (2017-05-01 23:30:11 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:41:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1e2d1ed8a403ce0e350aebadd12...

Powered by Google App Engine
This is Rietveld 408576698