Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2852133002:
Remove PAC-fetching URLRequestContext. (Closed)
DescriptionRemove PAC-fetching URLRequestContext.
Instead, the IOThread now uses the system URLRequestContext to fetch
PAC scripts (ProfileIOData was switched to doing something similar in
an earlier CL).
BUG=715697
Review-Url: https://codereview.chromium.org/2852133002
Cr-Commit-Position: refs/heads/master@{#475576}
Committed: https://chromium.googlesource.com/chromium/src/+/ab0c11df9302ab76649b00bd8ceba4dd7f886a11
Patch Set 1 #Patch Set 2 : Fixes, add test #Patch Set 3 : Merge #Patch Set 4 : Fix, add test #Patch Set 5 : Uninteresting merge #Patch Set 6 : Really exciting merge #Patch Set 7 : Fix test #Patch Set 8 : Uninteresting merge #Patch Set 9 : Merge #Patch Set 10 : Merge #Patch Set 11 : Merge #Patch Set 12 : More upstream merge conflicts! Fun! #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 82 (77 generated)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Remove PAC=fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (I switched ProfileIOData over in an earlier CL). BUG= ========== to ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (I switched ProfileIOData over in an earlier CL). BUG= ==========
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (I switched ProfileIOData over in an earlier CL). BUG= ========== to ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (I switched ProfileIOData over in an earlier CL). BUG=715697 ==========
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #5 (id:80001) has been deleted
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #11 (id:220001) has been deleted
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #9 (id:180001) has been deleted
Patchset #9 (id:200001) has been deleted
Patchset #4 (id:60001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #6 (id:240001) has been deleted
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
mmenke@chromium.org changed reviewers: + eroman@chromium.org
Another fun proxy CL! This is likely the last one before I start hooking up proxy configuration to the network service.
Description was changed from ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (I switched ProfileIOData over in an earlier CL). BUG=715697 ========== to ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (ProfileIOData was swtiched to doing this in an earlier CL). BUG=715697 ==========
Description was changed from ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (ProfileIOData was swtiched to doing this in an earlier CL). BUG=715697 ========== to ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (ProfileIOData was switched to doing something similar in an earlier CL). BUG=715697 ==========
No rush in reviewing this one - want to figure out https://crbug.com/723589 before landing this, as there's a possibility it's related to my CLs, and I won't want to deepen the chain until it's resolved.
lgtm!
The CQ bit was checked by mmenke@chromium.org
The CQ bit was unchecked by mmenke@chromium.org
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmenke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/2852133002/#ps380001 (title: "More upstream merge conflicts! Fun!")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 380001, "attempt_start_ts": 1496159030811310,
"parent_rev": "1a3243be1c3675b74e93ebc44d496f5e9855ee11", "commit_rev":
"ab0c11df9302ab76649b00bd8ceba4dd7f886a11"}
Message was sent while issue was closed.
Description was changed from ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (ProfileIOData was switched to doing something similar in an earlier CL). BUG=715697 ========== to ========== Remove PAC-fetching URLRequestContext. Instead, the IOThread now uses the system URLRequestContext to fetch PAC scripts (ProfileIOData was switched to doing something similar in an earlier CL). BUG=715697 Review-Url: https://codereview.chromium.org/2852133002 Cr-Commit-Position: refs/heads/master@{#475576} Committed: https://chromium.googlesource.com/chromium/src/+/ab0c11df9302ab76649b00bd8ceb... ==========
Message was sent while issue was closed.
Committed patchset #12 (id:380001) as https://chromium.googlesource.com/chromium/src/+/ab0c11df9302ab76649b00bd8ceb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
