Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2852103002: Revert of Implementing Binary glTF reader for the VR controller model (Closed)

Created:
3 years, 7 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 7 months ago
Reviewers:
acondor_, mthiesse, bajones
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implementing Binary glTF reader for the VR controller model (patchset #3 id:40001 of https://codereview.chromium.org/2852533004/ ) Reason for revert: Test added in this patch fails on downstream bot (see http://crbug.com/717088) BUG=717088 Original issue's description: > Implementing Binary glTF reader for the VR controller model > > The binary glTF format enables us to deliver 3D models on a single file with minimal size. > > Binary glTF Specification in: https://github.com/KhronosGroup/glTF/tree/master/extensions/Khronos/KHR_binary_glTF > > BUG=644562 > > Review-Url: https://codereview.chromium.org/2852533004 > Cr-Commit-Position: refs/heads/master@{#468198} > Committed: https://chromium.googlesource.com/chromium/src/+/b416391e0ae62217afb7ea5ffeb04ab2640a96ed TBR=mthiesse@chromium.org,bajones@chromium.org,acondor@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644562 Review-Url: https://codereview.chromium.org/2852103002 Cr-Commit-Position: refs/heads/master@{#468338} Committed: https://chromium.googlesource.com/chromium/src/+/1f02534fb0fb3a45f76c16d06da2b46c0625a668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -137 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/gltf_parser.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/android/vr_shell/gltf_parser.cc View 6 chunks +1 line, -93 lines 0 comments Download
M chrome/browser/android/vr_shell/gltf_parser_unittest.cc View 3 chunks +1 line, -26 lines 0 comments Download
D chrome/browser/android/vr_shell/test/data/sample.glb View Binary file 0 comments Download
M chrome/browser/android/vr_shell/vr_controller_model.cc View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
aelias_OOO_until_Jul13
Created Revert of Implementing Binary glTF reader for the VR controller model
3 years, 7 months ago (2017-05-01 17:13:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852103002/1
3 years, 7 months ago (2017-05-01 17:14:26 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:15:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f02534fb0fb3a45f76c16d06da2...

Powered by Google App Engine
This is Rietveld 408576698