Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2852043002:
Add a flag to enable Translate Compact Infobar on Android. (Closed)
|
Created:
3 years, 7 months ago by Leo Modified:
3 years, 7 months ago Reviewers:
Andrew Hayden (chromium.org), hajimehoshi, groby-ooo-7-16, Takashi Toyoshima, groby1, haraken, Ilya Sherman, gone CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd translate::kTranslateCompactUI to chrome://flags page
BUG=703887
TBR=groby@chromium.org
Review-Url: https://codereview.chromium.org/2852043002
Cr-Commit-Position: refs/heads/master@{#469599}
Committed: https://chromium.googlesource.com/chromium/src/+/bc47e0b36caecbe801f44e6c45c87da31f4243bc
Patch Set 1 #Patch Set 2 : fix LoginCustomFlags #
Total comments: 5
Patch Set 3 : fix #
Messages
Total messages: 37 (23 generated)
Description was changed from ========== Add a flag to enable Translate Compact Infobar on Android. BUG=703887 ========== to ========== Add translate::kTranslateCompactUI to chrome://flags page BUG=703887 ==========
googleo@chromium.org changed reviewers: + groby@chromium.org
The CQ bit was checked by googleo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hey Rachel, As we have completed most features required by PM for the project "Translate UI redesign", I am going to add the feature flag for PMs/UXs to enable it and verify whether it works as expected. I have tested this patch on my local deices. https://screenshot.googleplex.com/ipTOrgwGjYD Hope it works on the daily build too. Thanks
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by googleo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
googleo@chromium.org changed reviewers: + haraken@chromium.org
haraken@chromium.org: Please review changes in histograms.xml I copied the the 2 lines from the failed test error message on https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.andro... Thanks
haraken@chromium.org changed reviewers: + isherman@chromium.org
+isherman for histograms (I'm eligible to review UseCounter-only changes.)
histograms.xml lgtm
dfalcantara@chromium.org changed reviewers: + dfalcantara@chromium.org
lgtm https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/about_fl... File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/about_fl... chrome/browser/about_flags.cc:1589: #if defined(OS_ANDROID) can you just combine this OS_ANDROID block with the one above? (remove lines 1588 & 1589) https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/flag_des... File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/flag_des... chrome/browser/flag_descriptions.cc:1353: definitely combine with previous block https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/flag_des... File chrome/browser/flag_descriptions.h (right): https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/flag_des... chrome/browser/flag_descriptions.h:1511: combine with the block in 1484?
On 2017/05/03 19:23:40, Ilya Sherman wrote: > histograms.xml lgtm Seems the ownership approval for histograms.xml is still missing, Do you know who can approve this?
On 2017/05/04 01:48:29, Leo wrote: > On 2017/05/03 19:23:40, Ilya Sherman wrote: > > histograms.xml lgtm > > Seems the ownership approval for histograms.xml is still missing, Do you know > who can approve this? He's got ownership. The chromium extensions for showing ownership don't know how to handle that directory's OWNERS file.
The CQ bit was checked by googleo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from isherman@chromium.org, dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2852043002/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
googleo@chromium.org changed reviewers: - groby@chromium.org
googleo@chromium.org changed reviewers: + andrewhayden@chromium.org, groby@chromium.org, hajimehoshi@chromium.org, toyoshim@chromium.org
Hey andrewhayden@, groby@, hajimehoshi@, toyoshim@ Need LGTM from an OWNER for these files: components/translate/core/browser/translate_infobar_delegate.cc components/translate/core/browser/translate_infobar_delegate.h I moved the original flag out from an anonymous namespace, so it can be used by chrome/browser/about_flags.cc. https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/about_fl... File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/about_fl... chrome/browser/about_flags.cc:1589: #if defined(OS_ANDROID) On 2017/05/04 01:37:07, slow (dfalcantara) wrote: > can you just combine this OS_ANDROID block with the one above? (remove lines > 1588 & 1589) Done. https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/flag_des... File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2852043002/diff/20001/chrome/browser/flag_des... chrome/browser/flag_descriptions.cc:1353: On 2017/05/04 01:37:07, slow (dfalcantara) wrote: > definitely combine with previous block Done.
Description was changed from ========== Add translate::kTranslateCompactUI to chrome://flags page BUG=703887 ========== to ========== Add translate::kTranslateCompactUI to chrome://flags page BUG=703887 TBR=groby@chromium.org ==========
The CQ bit was checked by googleo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493960825711380,
"parent_rev": "26c1afe367d2d3cb3905cc60d69abe91ce21dd72", "commit_rev":
"bc47e0b36caecbe801f44e6c45c87da31f4243bc"}
Message was sent while issue was closed.
Description was changed from ========== Add translate::kTranslateCompactUI to chrome://flags page BUG=703887 TBR=groby@chromium.org ========== to ========== Add translate::kTranslateCompactUI to chrome://flags page BUG=703887 TBR=groby@chromium.org Review-Url: https://codereview.chromium.org/2852043002 Cr-Commit-Position: refs/heads/master@{#469599} Committed: https://chromium.googlesource.com/chromium/src/+/bc47e0b36caecbe801f44e6c45c8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/bc47e0b36caecbe801f44e6c45c8...
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
groby@google.com changed reviewers: + groby@google.com
Message was sent while issue was closed.
lgtm, and apologies for missing this! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
