Add SwapMetricsObserverMac

Add SwapMetricsObserverMac

This CL adds SwapMetricsObserverMac which records macOS specific swap
metrics. Metrics includes:
- # of pages swapins/swapouts per seconds
- # of pages compressed/decompressed per seconds

These stats come from host_statistics64().

BUG=617492
Review-Url: https://codereview.chromium.org/2852033002
Cr-Commit-Position: refs/heads/master@{#468508}
Committed: https://chromium.googlesource.com/chromium/src/+/651d8feadbd84df44c2c09ca287d82cba7fd8dbf

[bashi, 2017-05-01 05:16:20]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 05:16:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 05:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 05:31:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bashi, 2017-05-01 05:50:44]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 05:50:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-05-01 06:39:16]

bashi@chromium.org changed reviewers:
+ erikchen@chromium.org, shrike@chromium.org

[bashi, 2017-05-01 06:39:16]

shrike@, erikchen@: PTAL

[commit-bot: I haz the power, 2017-05-01 06:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 06:53:33]

Dry run: This issue passed the CQ dry run.

[erikchen, 2017-05-01 12:19:58]

lgtm

https://codereview.chromium.org/2852033002/diff/20001/content/browser/memory/...
File content/browser/memory/swap_metrics_observer_mac.cc (right):

https://codereview.chromium.org/2852033002/diff/20001/content/browser/memory/...
content/browser/memory/swap_metrics_observer_mac.cc:28: int result =
the type should be kern_return_t.

[shrike, 2017-05-01 16:08:39]

lgtm

[bashi, 2017-05-01 22:02:13]

bashi@chromium.org changed reviewers:
+ isherman@chromium.org

[bashi, 2017-05-01 22:02:13]

isherman@: could you review histograms.xml?

https://codereview.chromium.org/2852033002/diff/20001/content/browser/memory/...
File content/browser/memory/swap_metrics_observer_mac.cc (right):

https://codereview.chromium.org/2852033002/diff/20001/content/browser/memory/...
content/browser/memory/swap_metrics_observer_mac.cc:28: int result =
On 2017/05/01 12:19:58, erikchen wrote:
> the type should be kern_return_t.

Ack. Will change.

[Ilya Sherman, 2017-05-01 22:25:32]

Metrics LGTM, thanks.

[bashi, 2017-05-01 23:00:52]

bashi@chromium.org changed reviewers:
+ jam@chromium.org

[bashi, 2017-05-01 23:00:52]

jam@: Could you review content/browser/BUILD.gn ?

[bashi, 2017-05-01 23:23:49]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 23:24:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-05-01 23:47:56]

lgtm

also please consider adding content/browser/memory/BUILD.gn so you don't need
reviews from others

[commit-bot: I haz the power, 2017-05-02 00:33:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 00:33:51]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-05-02 00:36:28]

On 2017/05/01 23:47:56, jam wrote:
> lgtm
> 
> also please consider adding content/browser/memory/BUILD.gn so you don't need
> reviews from others

Thanks. I'll add content/browser/memory/BUILD.gn in a follow-up CL.

[bashi, 2017-05-02 00:36:38]

The CQ bit was checked by bashi@chromium.org

[bashi, 2017-05-02 00:36:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, erikchen@chromium.org, shrike@chromium.org
Link to the patchset: https://codereview.chromium.org/2852033002/#ps40001
(title: "kern_return_t")

[commit-bot: I haz the power, 2017-05-02 00:37:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 00:42:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493685398534870,
"parent_rev": "586c01de3897c0aa2d9911ff703c51595cf22f62", "commit_rev":
"651d8feadbd84df44c2c09ca287d82cba7fd8dbf"}

[commit-bot: I haz the power, 2017-05-02 00:42:28]

Description was changed from

==========
Add SwapMetricsObserverMac

This CL adds SwapMetricsObserverMac which records macOS specific swap
metrics. Metrics includes:
- # of pages swapins/swapouts per seconds
- # of pages compressed/decompressed per seconds

These stats come from host_statistics64().

BUG=617492
==========

to

==========
Add SwapMetricsObserverMac

This CL adds SwapMetricsObserverMac which records macOS specific swap
metrics. Metrics includes:
- # of pages swapins/swapouts per seconds
- # of pages compressed/decompressed per seconds

These stats come from host_statistics64().

BUG=617492

Review-Url: https://codereview.chromium.org/2852033002
Cr-Commit-Position: refs/heads/master@{#468508}
Committed:
https://chromium.googlesource.com/chromium/src/+/651d8feadbd84df44c2c09ca287d...
==========

[commit-bot: I haz the power, 2017-05-02 00:42:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/651d8feadbd84df44c2c09ca287d...