Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2852023002:
Add PRESUMIT for accessibility_mode_enums values (Closed)
|
Created:
3 years, 7 months ago by dougt Modified:
3 years, 6 months ago CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd PRESUMIT for accessibility_mode_enums values
Values in content/common/accessibility_mode_enums.h need to be kept in
sync with content/browser/resources/accessibility/accessibility.js. It's
easy to forget and we should have a PRESUBMIT guarding against mistakes.
BUG=692087
Review-Url: https://codereview.chromium.org/2852023002
Cr-Commit-Position: refs/heads/master@{#482174}
Committed: https://chromium.googlesource.com/chromium/src/+/96252c9df30022a3c734bc03dea7b1c73e5de23c
Patch Set 1 #Patch Set 2 : ws #
Total comments: 6
Patch Set 3 : Address brettw's comments #
Messages
Total messages: 38 (26 generated)
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dougt@chromium.org changed reviewers: + aboxhall@chromium.org
Hi Alice, PTAL at the changes to the AccessibilityMode. I removed kOff because it's not used and we don't define it in the associated c++ header. I also renamed the complex types to match content/common/accessibility_mode.h.
dougt@chromium.org changed reviewers: + dmazzoni@chromium.org
PTAL
Alice, did you want to take a look? Minor nit - the Python script has inconsistent indentation, please switch to 2 spaces throughout.
lgtm modulo previous comment about indentation
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dougt@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
brettw, ptal at the presubmit change. need your approval for content/common/*
Can you ask a content owner instead? They will have more context.
dougt@chromium.org changed reviewers: + jam@chromium.org - brettw@chromium.org
jam, ptal.
brettw@chromium.org changed reviewers: + brettw@chromium.org
lgtm https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... File content/common/PRESUBMIT.py (right): https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... content/common/PRESUBMIT.py:12: # Given a full path to c++ header, return an array of the first This seems to return many items, so I'm getting confused by the word "first" in this comment. https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... content/common/PRESUBMIT.py:24: continue My Python is rusty, but is this continue statement doing anything? I thought it just goes back to the top of the loop. Can we delete it? https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... content/common/PRESUBMIT.py:60: # Make sure that the modes defined in the C++ header match those deifned in "deifned"
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:60001) has been deleted
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dougt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org, brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2852023002/#ps80001 (title: "Address brettw's comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498418385353440,
"parent_rev": "ac76448402d65a2f5dc9ccea07916f009960e0b0", "commit_rev":
"96252c9df30022a3c734bc03dea7b1c73e5de23c"}
Message was sent while issue was closed.
Description was changed from ========== Add PRESUMIT for accessibility_mode_enums values Values in content/common/accessibility_mode_enums.h need to be kept in sync with content/browser/resources/accessibility/accessibility.js. It's easy to forget and we should have a PRESUBMIT guarding against mistakes. BUG=692087 ========== to ========== Add PRESUMIT for accessibility_mode_enums values Values in content/common/accessibility_mode_enums.h need to be kept in sync with content/browser/resources/accessibility/accessibility.js. It's easy to forget and we should have a PRESUBMIT guarding against mistakes. BUG=692087 Review-Url: https://codereview.chromium.org/2852023002 Cr-Commit-Position: refs/heads/master@{#482174} Committed: https://chromium.googlesource.com/chromium/src/+/96252c9df30022a3c734bc03dea7... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/96252c9df30022a3c734bc03dea7...
Message was sent while issue was closed.
https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... File content/common/PRESUBMIT.py (right): https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... content/common/PRESUBMIT.py:12: # Given a full path to c++ header, return an array of the first On 2017/06/20 16:48:00, brettw wrote: > This seems to return many items, so I'm getting confused by the word "first" in > this comment. In a c++ there may be multiple static constexpr defined. I can adjust the comment. https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... content/common/PRESUBMIT.py:24: continue On 2017/06/20 16:48:01, brettw wrote: > My Python is rusty, but is this continue statement doing anything? I thought it > just goes back to the top of the loop. Can we delete it? Done. https://codereview.chromium.org/2852023002/diff/20001/content/common/PRESUBMI... content/common/PRESUBMIT.py:60: # Make sure that the modes defined in the C++ header match those deifned in On 2017/06/20 16:48:00, brettw wrote: > "deifned" Done. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
