Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2851953003: Change 'enum' -> 'union' in tagged union example. (Closed)

Created:
3 years, 7 months ago by Randy Smith (Not in Mondays)
Modified:
3 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change 'enum' -> 'union' in tagged union example. R=yzshen@chromium.org Review-Url: https://codereview.chromium.org/2851953003 Cr-Commit-Position: refs/heads/master@{#468256} Committed: https://chromium.googlesource.com/chromium/src/+/67525cc21428aa4c1f84968f147fc1cdb91ac864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/bindings/README.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Randy Smith (Not in Mondays)
Yuzshu: I found what I think is a typo in the mojo docs, and I ...
3 years, 7 months ago (2017-04-29 21:01:21 UTC) #1
yzshen1
LGTM! Thanks!
3 years, 7 months ago (2017-04-30 18:10:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851953003/1
3 years, 7 months ago (2017-04-30 20:21:20 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-30 21:15:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67525cc21428aa4c1f84968f147f...

Powered by Google App Engine
This is Rietveld 408576698