Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2851933002: [MD settings] correct category for SUBRESOURCE_FILTER (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] correct category for SUBRESOURCE_FILTER This CL changes the SUBRESOURCE_FITER which is not a valid category type to SUBRESOURCE_FILTER which is valid. BUG=716661 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2851933002 Cr-Commit-Position: refs/heads/master@{#468426} Committed: https://chromium.googlesource.com/chromium/src/+/ead067449e3b29c287c9ab871da2e7bc896843eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 7 months ago (2017-04-28 23:40:27 UTC) #5
tommycli
lgtm
3 years, 7 months ago (2017-05-01 15:53:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851933002/1
3 years, 7 months ago (2017-05-01 18:52:45 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:44:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ead067449e3b29c287c9ab871da2...

Powered by Google App Engine
This is Rietveld 408576698