Issue 285193006: Don't set QUIC's write alarm if we are connection flow control blocked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 285193006: Don't set QUIC's write alarm if we are connection flow control blocked. (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Robbie Shade

Base URL:
https://chromium.googlesource.com/chromium/src

Visibility:
Public.

More Reviews

Description

Don't set QUIC's write alarm if we are connection flow control blocked. Added QUIC_VERSION_19 to kSupportedQuicVersions. Merge internal change: 67141668 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -52 lines)			Patch
M	net/quic/quic_connection.h	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_connection_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_session.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_session.cc	View	5 chunks	+30 lines, -9 lines	0 comments	Download
M	net/quic/quic_session_test.cc	View	9 chunks	+51 lines, -8 lines	0 comments	Download
M	net/quic/quic_write_blocked_list.h	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	net/quic/quic_write_blocked_list_test.cc	View	6 chunks	+14 lines, -10 lines	0 comments	Download
M	net/quic/reliable_quic_stream_test.cc	View	12 chunks	+15 lines, -11 lines	0 comments	Download
M	net/quic/test_tools/quic_session_peer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_session_peer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi Robbie, Thanks very much for the fix. Connection flow control worked on my release ...

6 years, 7 months ago (2014-05-15 22:13:56 UTC) #2

lgtm

Expand Messages | Collapse Messages