net/quic/quic_connection.cc - Issue 285193006: Don't set QUIC's write alarm if we are connection flow control blocked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection.cc

Issue 285193006: Don't set QUIC's write alarm if we are connection flow control blocked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_connection.cc

diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc

index 3c08ef265fc18abe2943160d43d216eafc57f819..523ce6ecef8b184822955d4de1a8177f8cb66316 100644

--- a/net/quic/quic_connection.cc

+++ b/net/quic/quic_connection.cc

@@ -1157,7 +1157,8 @@ void QuicConnection::OnCanWrite() {

// After the visitor writes, it may have caused the socket to become write

// blocked or the congestion manager to prohibit sending, so check again.

- if (visitor_->HasPendingWrites() && !resume_writes_alarm_->IsSet() &&

+ if (visitor_->WillingAndAbleToWrite() &&

+ !resume_writes_alarm_->IsSet() &&

CanWrite(NOT_RETRANSMISSION, HAS_RETRANSMITTABLE_DATA)) {

// We're not write blocked, but some stream didn't write out all of its

// bytes. Register for 'immediate' resumption so we'll keep writing after

« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »