Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: components/google/core/browser/google_url_tracker_client.h

Issue 285193002: Create GoogleURLTrackerClient interface and //chrome implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/google/core/browser/google_url_tracker_client.h
diff --git a/components/google/core/browser/google_url_tracker_client.h b/components/google/core/browser/google_url_tracker_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..456b52369ecdcccafafa070239713f787fd75947
--- /dev/null
+++ b/components/google/core/browser/google_url_tracker_client.h
@@ -0,0 +1,34 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_GOOGLE_GOOGLE_URL_TRACKER_CLIENT_H_
+#define COMPONENTS_GOOGLE_GOOGLE_URL_TRACKER_CLIENT_H_
+
+class GoogleURLTracker;
+
+// Interface by which GoogleURLTracker communicates with its embedder.
+class GoogleURLTrackerClient {
+ public:
+ GoogleURLTrackerClient();
+ virtual ~GoogleURLTrackerClient() {}
Peter Kasting 2014/05/15 21:19:21 Nit: Since we now have a .cc file and the class is
blundell 2014/05/16 08:29:26 Done.
+
+ // Sets the GoogleURLTracker that is associated with this client.
+ void set_google_url_tracker(GoogleURLTracker* tracker) { tracker_ = tracker; }
Peter Kasting 2014/05/15 21:19:21 Nit: Google style guide says accessors should matc
blundell 2014/05/16 08:29:26 Done.
+
+ // Enables or disables listening for navigation starts. OnNavigationPending
+ // will be called for each navigation start if listening is enabled.
+ virtual void SetListeningForNavigationStart(bool listen) = 0;
+
+ // Returns whether or not the client is currently listening for navigation
+ // starts.
+ virtual bool IsListeningForNavigationStart() = 0;
+
+ protected:
+ GoogleURLTracker* google_url_tracker() { return tracker_; }
+
+ private:
+ GoogleURLTracker* tracker_;
+};
Peter Kasting 2014/05/15 21:19:21 Nit: DISALLOW_COPY_AND_ASSIGN
blundell 2014/05/16 08:29:26 Done.
+
+#endif // COMPONENTS_GOOGLE_GOOGLE_URL_TRACKER_CLIENT_H_

Powered by Google App Engine
This is Rietveld 408576698