Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2203)

Unified Diff: components/data_use_measurement/core/data_use_measurement.h

Issue 2851923002: Fix overflow in user traffic content type histogram (Closed)
Patch Set: change array to int16 and added test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_measurement.h
diff --git a/components/data_use_measurement/core/data_use_measurement.h b/components/data_use_measurement/core/data_use_measurement.h
index 931d6f1033d3a1fc50652411e3e6dd8e864d807f..d0e37c1ffb751c12ce7ee84ff78ba777042fa61d 100644
--- a/components/data_use_measurement/core/data_use_measurement.h
+++ b/components/data_use_measurement/core/data_use_measurement.h
@@ -194,6 +194,10 @@ class DataUseMeasurement {
bool no_reads_since_background_;
#endif
+ // User traffic data use by content type is logged in 1KB increments. The
+ // remaining bytes are saved in this array until logged next time.
+ int16_t user_traffic_content_type_bytes_[DataUseUserData::TYPE_MAX];
+
DISALLOW_COPY_AND_ASSIGN(DataUseMeasurement);
};

Powered by Google App Engine
This is Rietveld 408576698