Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: components/data_use_measurement/core/data_use_measurement.h

Issue 2851923002: Fix overflow in user traffic content type histogram (Closed)
Patch Set: change array to int16 and added test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DATA_USE_MEASUREMENT_CONTENT_DATA_USE_MEASUREMENT_H_ 5 #ifndef COMPONENTS_DATA_USE_MEASUREMENT_CONTENT_DATA_USE_MEASUREMENT_H_
6 #define COMPONENTS_DATA_USE_MEASUREMENT_CONTENT_DATA_USE_MEASUREMENT_H_ 6 #define COMPONENTS_DATA_USE_MEASUREMENT_CONTENT_DATA_USE_MEASUREMENT_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 int64_t bytes_transferred_since_last_traffic_stats_query_; 187 int64_t bytes_transferred_since_last_traffic_stats_query_;
188 188
189 // The time at which Chromium app state changed to background. Can be null if 189 // The time at which Chromium app state changed to background. Can be null if
190 // app is not in background. 190 // app is not in background.
191 base::TimeTicks last_app_background_time_; 191 base::TimeTicks last_app_background_time_;
192 192
193 // True if app is in background and first network read has not yet happened. 193 // True if app is in background and first network read has not yet happened.
194 bool no_reads_since_background_; 194 bool no_reads_since_background_;
195 #endif 195 #endif
196 196
197 // User traffic data use by content type is logged in 1KB increments. The
198 // remaining bytes are saved in this array until logged next time.
199 int16_t user_traffic_content_type_bytes_[DataUseUserData::TYPE_MAX];
200
197 DISALLOW_COPY_AND_ASSIGN(DataUseMeasurement); 201 DISALLOW_COPY_AND_ASSIGN(DataUseMeasurement);
198 }; 202 };
199 203
200 } // namespace data_use_measurement 204 } // namespace data_use_measurement
201 205
202 #endif // COMPONENTS_DATA_USE_MEASUREMENT_CONTENT_DATA_USE_MEASUREMENT_H_ 206 #endif // COMPONENTS_DATA_USE_MEASUREMENT_CONTENT_DATA_USE_MEASUREMENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698