Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: components/payments/core/journey_logger.h

Issue 2851893002: [Payments] Record CanMakePayment metrics on Desktop. (Closed)
Patch Set: Windows Fix and Rebase Fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/core/journey_logger.h
diff --git a/components/payments/core/journey_logger.h b/components/payments/core/journey_logger.h
index c3330eb854043a3595a7dca6f3e90470adc6562e..a7e72bd81f39bab1e71035df8571c32aa65bdfb0 100644
--- a/components/payments/core/journey_logger.h
+++ b/components/payments/core/journey_logger.h
@@ -66,7 +66,7 @@ class JourneyLogger {
EVENT_PAY_CLICKED = 1 << 1,
EVENT_RECEIVED_INSTRUMENT_DETAILS = 1 << 2,
EVENT_SKIPPED_SHOW = 1 << 3,
- EVENT_MAX = 16,
+ EVENT_ENUM_MAX = 16,
};
// Used to mesure the impact of the CanMakePayment return value on whether the
@@ -157,9 +157,10 @@ class JourneyLogger {
void RecordUrlKeyedMetrics(CompletionStatus completion_status);
SectionStats sections_[NUMBER_OF_SECTIONS];
- bool was_can_make_payments_used_;
- bool could_make_payment_;
- bool was_show_called_;
+ bool has_recorded_ = false;
+ bool was_can_make_payments_used_ = false;
+ bool could_make_payment_ = false;
+ bool was_show_called_ = false;
bool is_incognito_;
// Accumulates the many events that have happened during the Payment Request.
« no previous file with comments | « components/payments/core/autofill_payment_instrument_unittest.cc ('k') | components/payments/core/journey_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698