Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: components/payments/core/journey_logger.cc

Issue 2851893002: [Payments] Record CanMakePayment metrics on Desktop. (Closed)
Patch Set: Windows Fix and Rebase Fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/payments/core/journey_logger.h ('k') | components/payments/core/payment_request_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/payments/core/journey_logger.cc
diff --git a/components/payments/core/journey_logger.cc b/components/payments/core/journey_logger.cc
index dc25cf6f1bf460dd3d7f797e7100f60d914ffbb8..11665b770cd09012252f156e45b1e64bf866dc45 100644
--- a/components/payments/core/journey_logger.cc
+++ b/components/payments/core/journey_logger.cc
@@ -67,10 +67,7 @@ std::string GetHistogramNameSuffix(
JourneyLogger::JourneyLogger(bool is_incognito,
const GURL& url,
ukm::UkmService* ukm_service)
- : was_can_make_payments_used_(false),
- could_make_payment_(false),
- was_show_called_(false),
- is_incognito_(is_incognito),
+ : is_incognito_(is_incognito),
events_(EVENT_INITIATED),
url_(url),
ukm_service_(ukm_service) {}
@@ -113,6 +110,9 @@ void JourneyLogger::SetEventOccurred(Event event) {
void JourneyLogger::RecordJourneyStatsHistograms(
CompletionStatus completion_status) {
+ DCHECK(!has_recorded_);
+ has_recorded_ = true;
+
RecordSectionSpecificStats(completion_status);
// Record the CanMakePayment metrics based on whether the transaction was
« no previous file with comments | « components/payments/core/journey_logger.h ('k') | components/payments/core/payment_request_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698