Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2851863003: Handle no cellular device more gracefully in choose-mobile-network UI. (Closed)

Created:
3 years, 7 months ago by Ben Chan
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle no cellular device more gracefully in choose-mobile-network UI. chrome://choose-mobile-network can be launched on a Chromebook without any cellular modem. This CL changes the UI to handle such case more gracefully: - Without overhauling the UI too much, the UI is changed to simply show 'No networks found'. - When the Cancel button is pressed, the UI performs nothing. BUG=714547 TEST=Tested the following: - Launch chrome://choose-mobile-network on a Chromebook without a cellular modem. Verify that the UI shows 'No networks found'. Click the Cancel button and verify that the UI doesn't crash. - Launch chrome://choose-mobile-network on a Chromebook with a cellular modem. Verify that the UI can populate a list of networks after successfully scanning for networks, and the Connect and Cancel button function correctly. Review-Url: https://codereview.chromium.org/2851863003 Cr-Commit-Position: refs/heads/master@{#468176} Committed: https://chromium.googlesource.com/chromium/src/+/5276c8837ad126b4ef5de6dd3216c18e81d5e6b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
stevenjb
Thanks! LGTM.
3 years, 7 months ago (2017-04-28 23:04:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851863003/1
3 years, 7 months ago (2017-04-28 23:16:02 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 23:22:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5276c8837ad126b4ef5de6dd3216...

Powered by Google App Engine
This is Rietveld 408576698