Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2851853003: Use dark scrollbar theme for transparent frames. (Closed)

Created:
3 years, 7 months ago by bokan
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Use dark scrollbar theme for transparent frames. If the given background color is totally transparent we should default to using the dark theme since that's the default. ChromeOS OOBE pages, for example, set an override background color of "TRANSPARENT" which is 00000000 in RGBA. Our old logic looked only at the RGB bits so it concluded that the frame had a black background and used white scollbars. We don't have enough information in Blink to know what theme to use in this case but falling back to the default theme should be good enough. BUG=709978 Review-Url: https://codereview.chromium.org/2840223002 Cr-Commit-Position: refs/heads/master@{#467382} (cherry picked from commit f82b1ff2761897b38ae79042810fb0a9f3ff747f) Review-Url: https://codereview.chromium.org/2851853003 . Cr-Commit-Position: refs/branch-heads/3071@{#305} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/115b23c07b6c2794b80190193300c83fa0d8c915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
3 years, 7 months ago (2017-04-28 22:03:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
115b23c07b6c2794b80190193300c83fa0d8c915.

Powered by Google App Engine
This is Rietveld 408576698