Remove LayoutObject::LayerCreationAllowedForSubtree.

Remove LayoutObject::LayerCreationAllowedForSubtree.

This method disallows PaintLayer creation inside a LayoutSVGHiddenContainer,
even for overflow-clipping elements that would normally require a PaintLayer.

This wreaks havoc in the layout code which assumes in numerous places that
HasOverflowClip() implies GetScrollableArea() != nullptr.

It was added in http://crrev.com/88e9d056 to fix a paint bug, but it seems
unnecessary now.  The svg/foreignObject layout tests all pass and the original
test case on http://wkbug.com/41386 still renders correctly after this change.

BUG=710087
Review-Url: https://codereview.chromium.org/2851763004
Cr-Commit-Position: refs/heads/master@{#468233}
Committed: https://chromium.googlesource.com/chromium/src/+/c566301a304c90ca1c1b05c9ed96e09b4c0392da

[skobes, 2017-04-28 23:41:12]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:41:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2017-04-28 23:44:26]

Description was changed from

==========
Remove LayoutObject::LayerCreationAllowedForSubtree.

This method disallows PaintLayer creation inside an LayoutSVGHiddenContainer,
even for overflow-clipping elements that would normally require a PaintLayer.

This wreaks havoc in the layout code which assumes in numerous places that
HasOverflowClip() implies GetScrollableArea() != nullptr.

It was added in http://crrev.com/88e9d056 to fix a paint bug, but it seems
unnecessary now.  The svg/foreignObject layout tests all pass and the original
test case on http://wkbug.com/41386 still renders correctly after this change.

BUG=710087
==========

to

==========
Remove LayoutObject::LayerCreationAllowedForSubtree.

This method disallows PaintLayer creation inside a LayoutSVGHiddenContainer,
even for overflow-clipping elements that would normally require a PaintLayer.

This wreaks havoc in the layout code which assumes in numerous places that
HasOverflowClip() implies GetScrollableArea() != nullptr.

It was added in http://crrev.com/88e9d056 to fix a paint bug, but it seems
unnecessary now.  The svg/foreignObject layout tests all pass and the original
test case on http://wkbug.com/41386 still renders correctly after this change.

BUG=710087
==========

[commit-bot: I haz the power, 2017-04-29 02:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 02:02:39]

Dry run: This issue passed the CQ dry run.

[skobes, 2017-04-29 02:09:57]

skobes@chromium.org changed reviewers:
+ szager@chromium.org

[skobes, 2017-04-29 02:09:58]

(please CQ for me if it LGTY)

[szager1, 2017-04-29 09:05:41]

The CQ bit was checked by szager@chromium.org

[szager1, 2017-04-29 09:05:42]

lgtm

[commit-bot: I haz the power, 2017-04-29 09:05:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 09:09:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493456741475430, "parent_rev":
"f291fca00b97533d9a958287bca80784edbab7f7", "commit_rev":
"c566301a304c90ca1c1b05c9ed96e09b4c0392da"}

[commit-bot: I haz the power, 2017-04-29 09:09:38]

Description was changed from

==========
Remove LayoutObject::LayerCreationAllowedForSubtree.

This method disallows PaintLayer creation inside a LayoutSVGHiddenContainer,
even for overflow-clipping elements that would normally require a PaintLayer.

This wreaks havoc in the layout code which assumes in numerous places that
HasOverflowClip() implies GetScrollableArea() != nullptr.

It was added in http://crrev.com/88e9d056 to fix a paint bug, but it seems
unnecessary now.  The svg/foreignObject layout tests all pass and the original
test case on http://wkbug.com/41386 still renders correctly after this change.

BUG=710087
==========

to

==========
Remove LayoutObject::LayerCreationAllowedForSubtree.

This method disallows PaintLayer creation inside a LayoutSVGHiddenContainer,
even for overflow-clipping elements that would normally require a PaintLayer.

This wreaks havoc in the layout code which assumes in numerous places that
HasOverflowClip() implies GetScrollableArea() != nullptr.

It was added in http://crrev.com/88e9d056 to fix a paint bug, but it seems
unnecessary now.  The svg/foreignObject layout tests all pass and the original
test case on http://wkbug.com/41386 still renders correctly after this change.

BUG=710087

Review-Url: https://codereview.chromium.org/2851763004
Cr-Commit-Position: refs/heads/master@{#468233}
Committed:
https://chromium.googlesource.com/chromium/src/+/c566301a304c90ca1c1b05c9ed96...
==========

[commit-bot: I haz the power, 2017-04-29 09:09:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c566301a304c90ca1c1b05c9ed96...