Update WindowManagerApplication teardown

Update WindowManagerApplication teardown

WindowManagerApplication's normal destruction order involves tearing down
everything is has created.

However on some fast tests it is possible for WindowManagerApplication to be
destroyed before OnStart is ever called. When this occurs we attempt to destroy
services which we never created, and various DCHECKS are triggered.

PhishingDOMFeatureExtractorTest.SubframeRemoval has a >50% repro rate of this
locally where the crash occurs after the test successfully passes.

TEST=PhishingDOMFeatureExtractorTest.SubframeRemoval
BUG=678687
Review-Url: https://codereview.chromium.org/2851763002
Cr-Commit-Position: refs/heads/master@{#468101}
Committed: https://chromium.googlesource.com/chromium/src/+/13d934bcc82c0e7ac86afe39fdede0a8d3b46d2a

[jonross, 2017-04-28 15:58:30]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-04-28 15:58:31]

Hey sky@,

Could you review this change to WindowManagerApplication?

Thanks,
Jon

[sky, 2017-04-28 17:54:36]

LGTM

[jonross, 2017-04-28 17:55:01]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-04-28 17:56:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 19:53:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493402101225040, "parent_rev":
"9eb381166018fa2be0d54a787dfcef8ab396e6e9", "commit_rev":
"13d934bcc82c0e7ac86afe39fdede0a8d3b46d2a"}

[commit-bot: I haz the power, 2017-04-28 19:54:01]

Description was changed from

==========
Update WindowManagerApplication teardown

WindowManagerApplication's normal destruction order involves tearing down
everything is has created.

However on some fast tests it is possible for WindowManagerApplication to be
destroyed before OnStart is ever called. When this occurs we attempt to destroy
services which we never created, and various DCHECKS are triggered.

PhishingDOMFeatureExtractorTest.SubframeRemoval has a >50% repro rate of this
locally where the crash occurs after the test successfully passes.

TEST=PhishingDOMFeatureExtractorTest.SubframeRemoval
BUG=678687
==========

to

==========
Update WindowManagerApplication teardown

WindowManagerApplication's normal destruction order involves tearing down
everything is has created.

However on some fast tests it is possible for WindowManagerApplication to be
destroyed before OnStart is ever called. When this occurs we attempt to destroy
services which we never created, and various DCHECKS are triggered.

PhishingDOMFeatureExtractorTest.SubframeRemoval has a >50% repro rate of this
locally where the crash occurs after the test successfully passes.

TEST=PhishingDOMFeatureExtractorTest.SubframeRemoval
BUG=678687

Review-Url: https://codereview.chromium.org/2851763002
Cr-Commit-Position: refs/heads/master@{#468101}
Committed:
https://chromium.googlesource.com/chromium/src/+/13d934bcc82c0e7ac86afe39fded...
==========

[commit-bot: I haz the power, 2017-04-28 19:54:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13d934bcc82c0e7ac86afe39fded...