[heap] Remove TryFinalizeIdleIncrementalMarking.

[heap] Remove TryFinalizeIdleIncrementalMarking.

We can use FinalizeIncrementalMarking instead since the only caller of
TryFinalizeIdleIncrementalMarking is IdleNotification, for which staying
within idle deadline is not critical.

This also fixes a bug caused by inconsistent code duplication in
finalization condition in the two functions.

BUG=v8:6325, chromium:715457
Review-Url: https://codereview.chromium.org/2851743002
Cr-Commit-Position: refs/heads/master@{#45054}
Committed: https://chromium.googlesource.com/v8/v8/+/a525d7c1643c76e18818cabcd9a6b2195505714d

[ulan, 2017-04-28 13:08:02]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2017-04-28 13:08:03]

ptal

[Hannes Payer (out of office), 2017-05-02 16:43:20]

lgtm

[ulan, 2017-05-02 16:45:50]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2017-05-02 16:45:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:10:05]

Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/26920)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[ulan, 2017-05-03 09:33:49]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-05-03 09:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2851743002/#ps20001
(title: "fix call-site")

[commit-bot: I haz the power, 2017-05-03 09:33:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 10:05:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493804029514620,
"parent_rev": "23ee74310b2d1aab30e1be3ae1fdba8850357734", "commit_rev":
"a525d7c1643c76e18818cabcd9a6b2195505714d"}

[commit-bot: I haz the power, 2017-05-03 10:05:47]

Description was changed from

==========
[heap] Remove TryFinalizeIdleIncrementalMarking.

We can use FinalizeIncrementalMarking instead since the only caller of
TryFinalizeIdleIncrementalMarking is IdleNotification, for which staying
within idle deadline is not critical.

This also fixes a bug caused by inconsistent code duplication in
finalization condition in the two functions.

BUG=v8:6325,chromium:715457
==========

to

==========
[heap] Remove TryFinalizeIdleIncrementalMarking.

We can use FinalizeIncrementalMarking instead since the only caller of
TryFinalizeIdleIncrementalMarking is IdleNotification, for which staying
within idle deadline is not critical.

This also fixes a bug caused by inconsistent code duplication in
finalization condition in the two functions.

BUG=v8:6325,chromium:715457

Review-Url: https://codereview.chromium.org/2851743002
Cr-Commit-Position: refs/heads/master@{#45054}
Committed:
https://chromium.googlesource.com/v8/v8/+/a525d7c1643c76e18818cabcd9a6b219550...
==========

[commit-bot: I haz the power, 2017-05-03 10:05:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a525d7c1643c76e18818cabcd9a6b219550...