Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2851703004: [Field trials] Allow default group names to be omitted. (Closed)

Created:
3 years, 7 months ago by Ilya Sherman
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Field trials] Allow default group names to be omitted. This was previously fixed for seed processing in http://crrev.com/2612243003, but was accidentally omitted for the simulation code. BUG=716493 R=asvitkine@chromium.org Review-Url: https://codereview.chromium.org/2851703004 Cr-Commit-Position: refs/heads/master@{#468218} Committed: https://chromium.googlesource.com/chromium/src/+/0bd5b87b3336e5ea16103902b59574f86663e5e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/variations/variations_seed_simulator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Ilya Sherman
3 years, 7 months ago (2017-04-29 01:28:19 UTC) #1
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-04-29 01:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851703004/1
3 years, 7 months ago (2017-04-29 01:47:23 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 03:11:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0bd5b87b3336e5ea16103902b595...

Powered by Google App Engine
This is Rietveld 408576698