Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2851703003: Revert of [tools/perf] Disable load:tools:drive system health story (Closed)

Created:
3 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tools/perf] Disable load:tools:drive system health story (patchset #1 id:1 of https://codereview.chromium.org/2848573002/ ) Reason for re-enabling the story: The V8 CL that was causing the crash has been reverted in https://crrev.com/2852623002 Original issue's description: > [tools/perf] Disable load:tools:drive system health story > > Story shows a high failure rate on many different perf bots. > > TBR=nednguyen@google.com > BUG=715936 > > Review-Url: https://codereview.chromium.org/2848573002 > Cr-Commit-Position: refs/heads/master@{#467640} > Committed: https://chromium.googlesource.com/chromium/src/+/3721c3608a5aef73b1762e6906257c9d9f8e0d36 BUG=715936 Review-Url: https://codereview.chromium.org/2851703003 Cr-Commit-Position: refs/heads/master@{#467958} Committed: https://chromium.googlesource.com/chromium/src/+/17cb970f145b4eb3df0c95ced62d38dbf521ca6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/page_sets/system_health/loading_stories.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Primiano Tucci (use gerrit)
Created Revert of [tools/perf] Disable load:tools:drive system health story
3 years, 7 months ago (2017-04-28 09:16:41 UTC) #1
Primiano Tucci (use gerrit)
PTAL, reenabling the story
3 years, 7 months ago (2017-04-28 09:17:23 UTC) #3
nednguyen(REVIEW IN OTHER ACC)
lgtm
3 years, 7 months ago (2017-04-28 09:22:07 UTC) #5
perezju
lgtm
3 years, 7 months ago (2017-04-28 09:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851703003/1
3 years, 7 months ago (2017-04-28 10:13:24 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 11:16:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17cb970f145b4eb3df0c95ced62d...

Powered by Google App Engine
This is Rietveld 408576698