Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2851683002: cros: Remove user directory when encryption migration fails. (Closed)

Created:
3 years, 7 months ago by fukino
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

cros: Remove user directory when encryption migration fails. When the migration UI is notified by cryptohome that cryptohome gets unexpected errors during migration and it gives up migration, we should remove the user's cryptohome to make sure that the user will be able to log in to the Desktop next time. After the user's cryptohome is removed, we get password verification errors on the existing user pod three times. It seems an independent issue, so I filed crbug.com/715474 and will look into separately. BUG=713556 TEST=manually tested by forcing cryptohome fail during migration and confirming the cryptohome is gone. TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2838303003 Cr-Commit-Position: refs/heads/master@{#467608} (cherry picked from commit 1339ec6addf0faa53da2c7418a0de5b6803d89cf) Review-Url: https://codereview.chromium.org/2851683002 . Cr-Commit-Position: refs/branch-heads/3071@{#285} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/fb47d19268582cdc5a16222901fc937472eb91be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 4 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 7 months ago (2017-04-28 06:01:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb47d19268582cdc5a16222901fc937472eb91be.

Powered by Google App Engine
This is Rietveld 408576698