[Mac] Fix for Page Info Bubble

[Mac] Fix for Page Info Bubble

Same issue with https://codereview.chromium.org/2752623003/
There's a potential with a race condition with the Page Info icon where
it might switch between LocationIconDecoration and
SecurityStateBubbleDecoration.

BUG=675854
Review-Url: https://codereview.chromium.org/2851663002
Cr-Commit-Position: refs/heads/master@{#468409}
Committed: https://chromium.googlesource.com/chromium/src/+/222d387eaf31fd6054c54fbd9f68227b2217e6b4

[spqchan, 2017-04-28 01:27:53]

Description was changed from

==========
[Mac] Fix for Page Info Bubble

BUG=
==========

to

==========
[Mac] Fix for Page Info Bubble

Same issue with https://codereview.chromium.org/2752623003/
There's a potential with a race condition with the Page Info icon

BUG=675854
==========

[spqchan, 2017-04-28 01:27:53]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2017-04-28 15:51:22]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 15:51:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 16:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 16:10:29]

Dry run: This issue passed the CQ dry run.

[spqchan, 2017-04-28 16:36:20]

PTAL

[Robert Sesek, 2017-04-28 17:26:50]

And how about a unittest? :)

https://codereview.chromium.org/2851663002/diff/1/chrome/browser/ui/cocoa/pag...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h (right):

https://codereview.chromium.org/2851663002/diff/1/chrome/browser/ui/cocoa/pag...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h:102: // info
icon has a special case where it might cause a race condition.
Please describe the race condition here and in the CL description.

[spqchan, 2017-04-28 23:10:50]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:11:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:31:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:31:35]

Dry run: This issue passed the CQ dry run.

[spqchan, 2017-05-01 18:06:11]

Description was changed from

==========
[Mac] Fix for Page Info Bubble

Same issue with https://codereview.chromium.org/2752623003/
There's a potential with a race condition with the Page Info icon

BUG=675854
==========

to

==========
[Mac] Fix for Page Info Bubble

Same issue with https://codereview.chromium.org/2752623003/
There's a potential with a race condition with the Page Info icon where
it might switch between LocationIconDecoration and
SecurityStateBubbleDecoration.

BUG=675854
==========

[spqchan, 2017-05-01 18:28:10]

PTAL

[spqchan, 2017-05-01 18:31:19]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 18:32:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 18:51:58]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-05-01 21:02:59]

LGTM

[spqchan, 2017-05-01 21:05:25]

On 2017/05/01 21:02:59, Robert Sesek wrote:
> LGTM

thanks!

[spqchan, 2017-05-01 21:05:32]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2017-05-01 21:06:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 21:12:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493672732220530,
"parent_rev": "648dc8df32f3eed0b0149b08148cd8a9b3e1c83c", "commit_rev":
"222d387eaf31fd6054c54fbd9f68227b2217e6b4"}

[commit-bot: I haz the power, 2017-05-01 21:12:11]

Description was changed from

==========
[Mac] Fix for Page Info Bubble

Same issue with https://codereview.chromium.org/2752623003/
There's a potential with a race condition with the Page Info icon where
it might switch between LocationIconDecoration and
SecurityStateBubbleDecoration.

BUG=675854
==========

to

==========
[Mac] Fix for Page Info Bubble

Same issue with https://codereview.chromium.org/2752623003/
There's a potential with a race condition with the Page Info icon where
it might switch between LocationIconDecoration and
SecurityStateBubbleDecoration.

BUG=675854

Review-Url: https://codereview.chromium.org/2851663002
Cr-Commit-Position: refs/heads/master@{#468409}
Committed:
https://chromium.googlesource.com/chromium/src/+/222d387eaf31fd6054c54fbd9f68...
==========

[commit-bot: I haz the power, 2017-05-01 21:12:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/222d387eaf31fd6054c54fbd9f68...