Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2851563002: [Telemetry] Switch Android platform to no longer uses test ca (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Switch Android platform to no longer uses test ca This means Telemetry will use "--ignore-certificate-errors" when launching Chrome on Android platform version < M Reenabling test ca is tracked in crbug.com/716084 ** PERF SHERIFFS **: this CL is expected to cause performance changes to Chrome. Please ignore any perf regression caused by this, since this is test change, and not a change to Chrome. BUG=chromium:716084, chromium:711634 Review-Url: https://codereview.chromium.org/2851563002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e80a730b1b1b43ec5fa205dd99e5f00693173f4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M telemetry/telemetry/internal/platform/android_platform_backend.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
nednguyen
3 years, 7 months ago (2017-04-27 17:27:33 UTC) #6
perezju
lgtm
3 years, 7 months ago (2017-04-28 08:15:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851563002/1
3 years, 7 months ago (2017-04-28 09:24:20 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 09:26:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698