Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 2851553002: Invalidate row/section for backgrounds when cell's geometry changes (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
index 14dc86695534739603ece0f62b1be09ef692d49e..8e0248c16513f7962cd817eab54b19d377ab0caa 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
@@ -34,6 +34,7 @@
#include "core/layout/SubtreeLayoutScope.h"
#include "core/paint/ObjectPaintInvalidator.h"
#include "core/paint/PaintLayer.h"
+#include "core/paint/TableCellPaintInvalidator.h"
#include "core/paint/TableCellPainter.h"
#include "core/style/CollapsedBorderValue.h"
#include "platform/geometry/FloatQuad.h"
@@ -1488,4 +1489,14 @@ bool LayoutTableCell::HasLineIfEmpty() const {
return LayoutBlock::HasLineIfEmpty();
}
+PaintInvalidationReason LayoutTableCell::InvalidatePaintIfNeeded(
+ const PaintInvalidatorContext& context) const {
wkorman 2017/04/27 22:30:23 Noting while reading -- Perhaps worth enhancing h
Xianzhu 2017/04/28 00:31:06 Good suggestion. I would like to do this in a sep
wkorman 2017/04/28 02:24:54 Acknowledged.
+ return TableCellPaintInvalidator(*this, context).InvalidatePaintIfNeeded();
+}
+
+PaintInvalidationReason LayoutTableCell::InvalidatePaintIfNeeded(
Xianzhu 2017/04/28 00:31:06 I would like to rename this to InvalidatePaintDepr
wkorman 2017/04/28 02:24:54 Sounds good.
+ const PaintInvalidationState& state) {
+ return LayoutBlockFlow::InvalidatePaintIfNeeded(state);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698