Invalidate row/section for backgrounds when cell's geometry changes

third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
  *               All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 16 matching lines @@
 
 #include "core/HTMLNames.h"
 #include "core/css/StylePropertySet.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/html/HTMLTableCellElement.h"
 #include "core/layout/LayoutAnalyzer.h"
 #include "core/layout/LayoutTableCol.h"
 #include "core/layout/SubtreeLayoutScope.h"
 #include "core/paint/ObjectPaintInvalidator.h"
 #include "core/paint/PaintLayer.h"
+#include "core/paint/TableCellPaintInvalidator.h"
 #include "core/paint/TableCellPainter.h"
 #include "core/style/CollapsedBorderValue.h"
 #include "platform/geometry/FloatQuad.h"
 #include "platform/geometry/TransformState.h"
 #include "platform/wtf/PtrUtil.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
@@ skipping 1434 matching lines @@
   r.Move(0, -IntrinsicPaddingBefore());
 }
 
 bool LayoutTableCell::HasLineIfEmpty() const {
   if (GetNode() && HasEditableStyle(*GetNode()))
     return true;
 
   return LayoutBlock::HasLineIfEmpty();
 }
 
+PaintInvalidationReason LayoutTableCell::InvalidatePaintIfNeeded(
+    const PaintInvalidatorContext& context) const {

[wkorman, 2017/04/27 22:30:23]

Noting while reading --

Perhaps worth enhancing
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/REA...
to incorporate discussion of PaintInvalidatorContext replacing
PaintInvalidationState.

I guess it's this TODO here:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/REA...

Also adding some class header docs noting similar for PaintInvalidatorContext
and PaintInvalidator classes.

[Xianzhu, 2017/04/28 00:31:06]

Good suggestion.

I would like to do this in a separate CL. For PaintInvalidationState I would
like to add "Deprecated" postfix instead of explaining it in README.md because
it will be removed soon (after M59 or M60 becomes stable).

[wkorman, 2017/04/28 02:24:54]

Acknowledged.

+  return TableCellPaintInvalidator(*this, context).InvalidatePaintIfNeeded();
+}
+
+PaintInvalidationReason LayoutTableCell::InvalidatePaintIfNeeded(

[Xianzhu, 2017/04/28 00:31:06]

I would like to rename this to InvalidatePaintDeprecated() in a follow-up so
that we don't need overriding the deprecated version when overriding the new
version.

[wkorman, 2017/04/28 02:24:54]

Sounds good.

+    const PaintInvalidationState& state) {
+  return LayoutBlockFlow::InvalidatePaintIfNeeded(state);
+}
+
 }  // namespace blink