Invalidate row/section for backgrounds when cell's geometry changes

third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Index: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
index 14dc86695534739603ece0f62b1be09ef692d49e..8e0248c16513f7962cd817eab54b19d377ab0caa 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
@@ -34,6 +34,7 @@
 #include "core/layout/SubtreeLayoutScope.h"
 #include "core/paint/ObjectPaintInvalidator.h"
 #include "core/paint/PaintLayer.h"
+#include "core/paint/TableCellPaintInvalidator.h"
 #include "core/paint/TableCellPainter.h"
 #include "core/style/CollapsedBorderValue.h"
 #include "platform/geometry/FloatQuad.h"
@@ -1488,4 +1489,14 @@ bool LayoutTableCell::HasLineIfEmpty() const {
   return LayoutBlock::HasLineIfEmpty();
 }
 
+PaintInvalidationReason LayoutTableCell::InvalidatePaintIfNeeded(
+    const PaintInvalidatorContext& context) const {

[wkorman, 2017/04/27 22:30:23]

Noting while reading --

Perhaps worth enhancing
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/REA...
to incorporate discussion of PaintInvalidatorContext replacing
PaintInvalidationState.

I guess it's this TODO here:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/REA...

Also adding some class header docs noting similar for PaintInvalidatorContext
and PaintInvalidator classes.

[Xianzhu, 2017/04/28 00:31:06]

Good suggestion.

I would like to do this in a separate CL. For PaintInvalidationState I would
like to add "Deprecated" postfix instead of explaining it in README.md because
it will be removed soon (after M59 or M60 becomes stable).

[wkorman, 2017/04/28 02:24:54]

Acknowledged.

+  return TableCellPaintInvalidator(*this, context).InvalidatePaintIfNeeded();
+}
+
+PaintInvalidationReason LayoutTableCell::InvalidatePaintIfNeeded(

[Xianzhu, 2017/04/28 00:31:06]

I would like to rename this to InvalidatePaintDeprecated() in a follow-up so
that we don't need overriding the deprecated version when overriding the new
version.

[wkorman, 2017/04/28 02:24:54]

Sounds good.

+    const PaintInvalidationState& state) {
+  return LayoutBlockFlow::InvalidatePaintIfNeeded(state);
+}
+
 }  // namespace blink