Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2851513005: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
CC:
apacible+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jasonroberts+watch_google.com, media-router+watch_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2851513005 Cr-Commit-Position: refs/heads/master@{#468896} Committed: https://chromium.googlesource.com/chromium/src/+/b62b8b5cc009826e378b6304f5632b4ef063725e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/media/cast_remoting_connector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/cast_remoting_connector.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc View 2 chunks +5 lines, -3 lines 1 comment Download

Messages

Total messages: 17 (9 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:46:52 UTC) #4
Avi (use Gerrit)
ping
3 years, 7 months ago (2017-05-02 01:31:41 UTC) #7
Avi (use Gerrit)
Can I get a quick review?
3 years, 7 months ago (2017-05-03 03:12:13 UTC) #9
DaleCurtis
Seems these should be MakeUnique with internal unique ptr usage? The new is just a ...
3 years, 7 months ago (2017-05-03 03:55:26 UTC) #10
Avi (use Gerrit)
On 2017/05/03 03:55:26, DaleCurtis wrote: > Seems these should be MakeUnique with internal unique ptr ...
3 years, 7 months ago (2017-05-03 04:02:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851513005/1
3 years, 7 months ago (2017-05-03 04:09:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b62b8b5cc009826e378b6304f5632b4ef063725e
3 years, 7 months ago (2017-05-03 04:56:32 UTC) #16
DaleCurtis
3 years, 7 months ago (2017-05-03 17:26:15 UTC) #17
Message was sent while issue was closed.
https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/cast_r...
File chrome/browser/media/cast_remoting_connector.cc (right):

https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/cast_r...
chrome/browser/media/cast_remoting_connector.cc:149:
contents->SetUserData(kUserDataKey, base::WrapUnique(connector));
I just meant this could be base::MakeUnique() by inlining the new call above.

https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc
(right):

https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/router...
chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc:29:
base::WrapUnique(new ReceiverPresentationServiceDelegateImpl(
Ditto. this is already wrapped so prefer MakeUnique.

Powered by Google App Engine
This is Rietveld 408576698