Switch SupportsUserData uses to use unique_ptr.

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
Review-Url: https://codereview.chromium.org/2851513005
Cr-Commit-Position: refs/heads/master@{#468896}
Committed: https://chromium.googlesource.com/chromium/src/+/b62b8b5cc009826e378b6304f5632b4ef063725e

[Avi (use Gerrit), 2017-04-29 01:49:42]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 01:50:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-04-29 02:46:51]

avi@chromium.org changed reviewers:
+ sergeyu@chromium.org

[commit-bot: I haz the power, 2017-04-29 02:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 02:49:09]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-05-02 01:31:41]

ping

[Avi (use Gerrit), 2017-05-03 03:12:13]

avi@chromium.org changed reviewers:
+ dalecurtis@chromium.org, hubbe@chromium.org

[Avi (use Gerrit), 2017-05-03 03:12:13]

Can I get a quick review?

[DaleCurtis, 2017-05-03 03:55:26]

Seems these should be MakeUnique with internal unique ptr usage? The new is just
a few lines above. lgtm otherwise though

[Avi (use Gerrit), 2017-05-03 04:02:53]

On 2017/05/03 03:55:26, DaleCurtis wrote:
> Seems these should be MakeUnique with internal unique ptr usage? The new is
just
> a few lines above. lgtm otherwise though

I used WrapUnique because the constructors are private. I'm not changing the
visibility of members of classes that aren't mine.

[Avi (use Gerrit), 2017-05-03 04:09:19]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-05-03 04:09:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 04:55:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493784559909050, "parent_rev":
"750b068d2182bbb0bafe9c236dae7aea02f0431e", "commit_rev":
"b62b8b5cc009826e378b6304f5632b4ef063725e"}

[commit-bot: I haz the power, 2017-05-03 04:56:31]

Description was changed from

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
==========

to

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2851513005
Cr-Commit-Position: refs/heads/master@{#468896}
Committed:
https://chromium.googlesource.com/chromium/src/+/b62b8b5cc009826e378b6304f563...
==========

[commit-bot: I haz the power, 2017-05-03 04:56:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b62b8b5cc009826e378b6304f563...

[DaleCurtis, 2017-05-03 17:26:15]

https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/cast_r...
File chrome/browser/media/cast_remoting_connector.cc (right):

https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/cast_r...
chrome/browser/media/cast_remoting_connector.cc:149:
contents->SetUserData(kUserDataKey, base::WrapUnique(connector));
I just meant this could be base::MakeUnique() by inlining the new call above.

https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc
(right):

https://codereview.chromium.org/2851513005/diff/1/chrome/browser/media/router...
chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc:29:
base::WrapUnique(new ReceiverPresentationServiceDelegateImpl(
Ditto. this is already wrapped so prefer MakeUnique.