Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: components/certificate_reporting/error_reporter_unittest.cc

Issue 2851493003: Remove unused CookiePreferences from report sender and never send cookies (Closed)
Patch Set: Fix iOS build Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/error_reporter_unittest.cc
diff --git a/components/certificate_reporting/error_reporter_unittest.cc b/components/certificate_reporting/error_reporter_unittest.cc
index 076049dd916465846a0b63a8dfad64fbf61db82e..1a3548dd4d6b08875b13dd77e00aea2917f29de5 100644
--- a/components/certificate_reporting/error_reporter_unittest.cc
+++ b/components/certificate_reporting/error_reporter_unittest.cc
@@ -46,8 +46,7 @@ void SuccessCallback(bool* called) {
// sent.
class MockCertificateReportSender : public net::ReportSender {
public:
- MockCertificateReportSender()
- : net::ReportSender(nullptr, DO_NOT_SEND_COOKIES) {}
+ MockCertificateReportSender() : net::ReportSender(nullptr) {}
~MockCertificateReportSender() override {}
void Send(
@@ -170,10 +169,9 @@ TEST_F(ErrorReporterTest, ErroredRequestCallsCallback) {
context.set_network_delegate(&test_delegate);
context.Init();
- GURL report_uri(
+ const GURL report_uri(
net::URLRequestFailedJob::GetMockHttpUrl(net::ERR_CONNECTION_FAILED));
- ErrorReporter reporter(&context, report_uri,
- net::ReportSender::DO_NOT_SEND_COOKIES);
+ ErrorReporter reporter(&context, report_uri);
bool error_callback_called = false;
bool success_callback_called = false;
@@ -197,9 +195,9 @@ TEST_F(ErrorReporterTest, SuccessfulRequestCallsCallback) {
context.set_network_delegate(&test_delegate);
context.Init();
- GURL report_uri(net::URLRequestMockDataJob::GetMockHttpUrl("some data", 1));
- ErrorReporter reporter(&context, report_uri,
- net::ReportSender::DO_NOT_SEND_COOKIES);
+ const GURL report_uri(
+ net::URLRequestMockDataJob::GetMockHttpUrl("some data", 1));
+ ErrorReporter reporter(&context, report_uri);
bool error_callback_called = false;
bool success_callback_called = false;

Powered by Google App Engine
This is Rietveld 408576698