Remove unused CookiePreferences from report sender and never send cookies

components/certificate_reporting/error_reporter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/certificate_reporting/error_reporter.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include <set>
@@ skipping 28 matching lines @@
 }
 
 void SuccessCallback(bool* called) {
   *called = true;
 }
 
 // A mock ReportSender that keeps track of the last report
 // sent.
 class MockCertificateReportSender : public net::ReportSender {
  public:
-  MockCertificateReportSender()
-      : net::ReportSender(nullptr, DO_NOT_SEND_COOKIES) {}
+  MockCertificateReportSender() : net::ReportSender(nullptr) {}
   ~MockCertificateReportSender() override {}
 
   void Send(
       const GURL& report_uri,
       base::StringPiece content_type,
       base::StringPiece report,
       const base::Callback<void()>& success_callback,
       const base::Callback<void(const GURL&, int)>& error_callback) override {
     latest_report_uri_ = report_uri;
     report.CopyToString(&latest_report_);
@@ skipping 102 matching lines @@
 TEST_F(ErrorReporterTest, ErroredRequestCallsCallback) {
   net::URLRequestFailedJob::AddUrlHandler();
 
   base::RunLoop run_loop;
   net::TestURLRequestContext context(true);
   TestCertificateReporterNetworkDelegate test_delegate;
   test_delegate.set_url_request_destroyed_callback(run_loop.QuitClosure());
   context.set_network_delegate(&test_delegate);
   context.Init();
 
-  GURL report_uri(
+  const GURL report_uri(
       net::URLRequestFailedJob::GetMockHttpUrl(net::ERR_CONNECTION_FAILED));
-  ErrorReporter reporter(&context, report_uri,
-                         net::ReportSender::DO_NOT_SEND_COOKIES);
+  ErrorReporter reporter(&context, report_uri);
 
   bool error_callback_called = false;
   bool success_callback_called = false;
   reporter.SendExtendedReportingReport(
       kDummyReport, base::Bind(&SuccessCallback, &success_callback_called),
       base::Bind(&ErrorCallback, &error_callback_called));
   run_loop.Run();
 
   EXPECT_TRUE(error_callback_called);
   EXPECT_FALSE(success_callback_called);
 }
 
 // Tests that an UMA histogram is recorded if a report fails to send.
 TEST_F(ErrorReporterTest, SuccessfulRequestCallsCallback) {
   net::URLRequestMockDataJob::AddUrlHandler();
 
   base::RunLoop run_loop;
   net::TestURLRequestContext context(true);
   TestCertificateReporterNetworkDelegate test_delegate;
   test_delegate.set_url_request_destroyed_callback(run_loop.QuitClosure());
   context.set_network_delegate(&test_delegate);
   context.Init();
 
-  GURL report_uri(net::URLRequestMockDataJob::GetMockHttpUrl("some data", 1));
-  ErrorReporter reporter(&context, report_uri,
-                         net::ReportSender::DO_NOT_SEND_COOKIES);
+  const GURL report_uri(
+      net::URLRequestMockDataJob::GetMockHttpUrl("some data", 1));
+  ErrorReporter reporter(&context, report_uri);
 
   bool error_callback_called = false;
   bool success_callback_called = false;
   reporter.SendExtendedReportingReport(
       kDummyReport, base::Bind(&SuccessCallback, &success_callback_called),
       base::Bind(&ErrorCallback, &error_callback_called));
   run_loop.Run();
 
   EXPECT_FALSE(error_callback_called);
   EXPECT_TRUE(success_callback_called);
@@ skipping 155 matching lines @@
   ASSERT_TRUE(encrypted_request.ParseFromString(
       std::string(reinterpret_cast<const char*>(kSerializedEncryptedReport),
                   sizeof(kSerializedEncryptedReport))));
   ASSERT_TRUE(ErrorReporter::DecryptErrorReport(
       server_private_key_, encrypted_request, &decrypted_serialized_report));
 }
 
 }  // namespace
 
 }  // namespace certificate_reporting