Remove unused CookiePreferences from report sender and never send cookies

Remove unused CookiePreferences from report sender and never send cookies

All non-test callers of ReportSender use CookiePreferences::DO_NOT_SEND_COOKIES.
Remove the enum altogether.

BUG=716098
Review-Url: https://codereview.chromium.org/2851493003
Cr-Commit-Position: refs/heads/master@{#468150}
Committed: https://chromium.googlesource.com/chromium/src/+/49c44f6ba26559359103400eb2480a832955d71f

[meacer, 2017-04-27 19:25:36]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[meacer, 2017-04-27 19:26:05]

Description was changed from

==========
Remove unused CookiePreferences flag, don't send cookies by default

BUG=716098
==========

to

==========
Remove unused CookiePreferences from report sender and never send cookies

BUG=716098
==========

[meacer, 2017-04-27 19:26:50]

Description was changed from

==========
Remove unused CookiePreferences from report sender and never send cookies

BUG=716098
==========

to

==========
Remove unused CookiePreferences from report sender and never send cookies

All non-test callers of ReportSender use CookiePreferences::DO_NOT_SEND_COOKIES.
Remove the enum altogether.

BUG=716098
==========

[commit-bot: I haz the power, 2017-04-27 19:33:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:44:57]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[meacer, 2017-04-27 19:46:19]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 19:47:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meacer, 2017-04-27 19:54:33]

meacer@chromium.org changed reviewers:
+ estark@chromium.org

[meacer, 2017-04-27 19:54:34]

PTAL?

[commit-bot: I haz the power, 2017-04-27 20:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:10:16]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estark, 2017-04-27 22:20:01]

lgtm. I wonder why we even had that lever... anyway, thanks for the cleanup.

[meacer, 2017-04-27 22:24:50]

meacer@chromium.org changed reviewers:
+ jialiul@chromium.org, rch@chromium.org, sdefresne@chromium.org

[meacer, 2017-04-27 22:24:51]

Owners, PTAL?

jialiul: chrome/safe_browsing/
rch: 	net/ and chrome/browser/profiles/profile_io_data.cc
sdefresne: ios/

Thanks.

[Jialiu Lin, 2017-04-28 00:03:16]

LGTM. Thanks for cleaning these up!

[Ryan Hamilton, 2017-04-28 03:29:34]

chrome/browser/profiles/profile_io_data.cc: LGTM

[Ryan Hamilton, 2017-04-28 03:29:37]

chrome/browser/profiles/profile_io_data.cc: LGTM

[sdefresne, 2017-04-28 10:12:55]

ios lgtm

https://codereview.chromium.org/2851493003/diff/20001/ios/chrome/browser/brow...
File ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc (right):

https://codereview.chromium.org/2851493003/diff/20001/ios/chrome/browser/brow...
ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc:366:
certificate_report_sender_.reset(
nit: can you change this to use base::MakeUnique?

  certificate_report_sender_ = base::MakeUnique<net::ReportSender>(
      main_request_context_.get());

[meacer, 2017-04-28 19:03:07]

https://codereview.chromium.org/2851493003/diff/20001/ios/chrome/browser/brow...
File ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc (right):

https://codereview.chromium.org/2851493003/diff/20001/ios/chrome/browser/brow...
ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc:366:
certificate_report_sender_.reset(
On 2017/04/28 10:12:54, sdefresne wrote:
> nit: can you change this to use base::MakeUnique?
> 
>   certificate_report_sender_ = base::MakeUnique<net::ReportSender>(
>       main_request_context_.get());

Done.

[meacer, 2017-04-28 19:03:16]

The CQ bit was checked by meacer@chromium.org

[meacer, 2017-04-28 19:03:17]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org,
sdefresne@chromium.org, jialiul@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2851493003/#ps40001
(title: "comments and rebase")

[commit-bot: I haz the power, 2017-04-28 19:04:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 19:15:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 19:15:56]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[meacer, 2017-04-28 19:33:54]

The CQ bit was checked by meacer@chromium.org

[meacer, 2017-04-28 19:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org,
sdefresne@chromium.org, jialiul@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2851493003/#ps60001
(title: "Fix rebase")

[commit-bot: I haz the power, 2017-04-28 19:35:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 21:04:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:04:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[meacer, 2017-04-28 21:22:48]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:23:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:06:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493414568169650,
"parent_rev": "10cd268f54d5f567b8834838ad0726e35dcdbe51", "commit_rev":
"49c44f6ba26559359103400eb2480a832955d71f"}

[commit-bot: I haz the power, 2017-04-28 22:06:22]

Description was changed from

==========
Remove unused CookiePreferences from report sender and never send cookies

All non-test callers of ReportSender use CookiePreferences::DO_NOT_SEND_COOKIES.
Remove the enum altogether.

BUG=716098
==========

to

==========
Remove unused CookiePreferences from report sender and never send cookies

All non-test callers of ReportSender use CookiePreferences::DO_NOT_SEND_COOKIES.
Remove the enum altogether.

BUG=716098

Review-Url: https://codereview.chromium.org/2851493003
Cr-Commit-Position: refs/heads/master@{#468150}
Committed:
https://chromium.googlesource.com/chromium/src/+/49c44f6ba26559359103400eb248...
==========

[commit-bot: I haz the power, 2017-04-28 22:06:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/49c44f6ba26559359103400eb248...