Network traffic annotation added to url_request_data_job_fuzzer.

Network traffic annotation added to url_request_data_job_fuzzer.

Network traffic annotation is added to network request of:
net/url_request/url_request_data_job_fuzzer.cc

BUG=656607
Review-Url: https://codereview.chromium.org/2851483002
Cr-Commit-Position: refs/heads/master@{#468900}
Committed: https://chromium.googlesource.com/chromium/src/+/a621e84a2cb1312957ceaafa7a8054ee7c176251

[Ramin Halavati, 2017-04-27 12:19:46]

rhalavati@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[Ramin Halavati, 2017-04-27 12:19:46]

Hi Julia,

Please suggest network traffic annotations for this file. Here are the
resources:

Please take a look at the protobuf scheme in:
https://cs.chromium.org/chromium/src/tools/traffic_annotation/traffic_annotat...
for the definition of the annotations.

You can find a sample annotation in:
https://cs.chromium.org/chromium/src/components/spellcheck/browser/spelling_s...

Entriprise policy options are here:
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/ch...

And more description on enterprise policy settings is here:
http://dev.chromium.org/administrators/policy-list-3

Please tell me if you need any clarifications from my side. If you want to learn
more, see:
https://docs.google.com/document/d/1FWEFTHzdqIA1wHUo_DuSpJjppW22otCMPCOA5NumhJU.

[Julia Tuttle, 2017-04-27 17:14:16]

I've never touched this file, but it looks like test code. Does it need an
annotation?

[Ramin Halavati, 2017-04-28 05:29:26]

Thank you Julia.
If it is test, it doesn't need annotation and I just replace annotation with a
flag for that. Would you prefer I do it so or you'd like someone else to review
it? If the latter, do you have any suggestion?

[Julia Tuttle, 2017-04-28 14:10:18]

On 2017/04/28 05:29:26, Ramin Halavati wrote:
> Thank you Julia.
> If it is test, it doesn't need annotation and I just replace annotation with a
> flag for that. Would you prefer I do it so or you'd like someone else to
review
> it? If the latter, do you have any suggestion?

Looking at git history, it looks like csharrison created and has been
maintaining the fuzzer, so he's probably a good choice.

[Charlie Harrison, 2017-04-28 15:58:06]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-04-28 15:58:06]

Hey Ramin,  this file doesn't need annotation since it is only run by
clusterfuzz test bots. If you don't mind changing this CL to just add a flag for
that it would be great.

[Ramin Halavati, 2017-05-02 05:17:57]

On 2017/04/28 15:58:06, Charlie (ooo-ish until may 2) wrote:
> Hey Ramin,  this file doesn't need annotation since it is only run by
> clusterfuzz test bots. If you don't mind changing this CL to just add a flag
for
> that it would be great.

Hi Charlie,

Thank you very much, changed it to TEST, please review.

[Charlie Harrison, 2017-05-02 05:25:55]

Thank you, LGTM. However, I am not an owner of //net so you will need OWNERS
approval for the change.

[Ramin Halavati, 2017-05-02 05:27:26]

On 2017/05/02 05:25:55, Charlie (ooo-ish until may 2) wrote:
> Thank you, LGTM. However, I am not an owner of //net so you will need OWNERS
> approval for the change.

Thank you Charlie.

Julia,
Could you please check this out?

[Julia Tuttle, 2017-05-02 15:52:10]

lgtm!

[Ramin Halavati, 2017-05-03 05:23:41]

The CQ bit was checked by rhalavati@chromium.org

[commit-bot: I haz the power, 2017-05-03 05:23:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 05:36:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493789021440020,
"parent_rev": "cb374e8d7a568886dd2bbf469c67f91de19fa4f3", "commit_rev":
"a621e84a2cb1312957ceaafa7a8054ee7c176251"}

[commit-bot: I haz the power, 2017-05-03 05:37:15]

Description was changed from

==========
Network traffic annotation added to url_request_data_job_fuzzer.

Network traffic annotation is added to network request of:
net/url_request/url_request_data_job_fuzzer.cc

BUG=656607
==========

to

==========
Network traffic annotation added to url_request_data_job_fuzzer.

Network traffic annotation is added to network request of:
net/url_request/url_request_data_job_fuzzer.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2851483002
Cr-Commit-Position: refs/heads/master@{#468900}
Committed:
https://chromium.googlesource.com/chromium/src/+/a621e84a2cb1312957ceaafa7a80...
==========

[commit-bot: I haz the power, 2017-05-03 05:37:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a621e84a2cb1312957ceaafa7a80...