Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2851423002: ChromeSecurityExploitBrowserTest: normalize whitespace for tests (Closed)

Created:
3 years, 7 months ago by Nate Fischer
Modified:
3 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeSecurityExploitBrowserTest: normalize whitespace for tests No change to production logic. The mobile layout an desktop layout for this page differ slightly in terms of white space (one layout has two newlines while one has only one). This causes failures when testing against the mobile layout. To address this, this CL squashes multiple newlines into a single one. BUG=717297 Review-Url: https://codereview.chromium.org/2851423002 Cr-Commit-Position: refs/heads/master@{#468669} Committed: https://chromium.googlesource.com/chromium/src/+/d9f4dd56083fb4ad41a8bc53bad9a24fa137b6f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/chrome_security_exploit_browsertest.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Nate Fischer
PTAL
3 years, 7 months ago (2017-05-01 23:42:33 UTC) #6
nasko
lgtm
3 years, 7 months ago (2017-05-02 05:31:06 UTC) #9
Nate Fischer
On 2017/05/02 05:31:06, nasko wrote: > lgtm Thanks, Nasko!
3 years, 7 months ago (2017-05-02 16:16:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851423002/1
3 years, 7 months ago (2017-05-02 16:16:36 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:21:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9f4dd56083fb4ad41a8bc53bad9...

Powered by Google App Engine
This is Rietveld 408576698