Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 2851303007: Replace AudioReceiveStream::Config with rtclog::StreamConfig. (Closed)

Created:
3 years, 7 months ago by perkj_webrtc
Modified:
3 years, 7 months ago
Reviewers:
the sun, terelius
CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace AudioReceiveStream::Config with rtclog::StreamConfig. BUG=webrtc:7538 Review-Url: https://codereview.webrtc.org/2851303007 Cr-Commit-Position: refs/heads/master@{#18223} Committed: https://chromium.googlesource.com/external/webrtc/+/ac8f52de7030bad3017f20f7c23d761ef0aeba68

Patch Set 1 #

Patch Set 2 : Fix rtc_event_log2text.cc. #

Patch Set 3 : Rebased #

Patch Set 4 : rebase #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -47 lines) Patch
M webrtc/call/call.cc View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 2 3 4 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log2text.cc View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 1 2 3 4 2 chunks +14 lines, -14 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (25 generated)
perkj_webrtc
Second cl.
3 years, 7 months ago (2017-05-02 10:46:40 UTC) #4
terelius
lgtm
3 years, 7 months ago (2017-05-19 17:10:19 UTC) #11
perkj_webrtc
Solenberg, and this please.
3 years, 7 months ago (2017-05-21 19:27:16 UTC) #13
the sun
On 2017/05/21 19:27:16, perkj_webrtc wrote: > Solenberg, and this please. lgtm
3 years, 7 months ago (2017-05-22 09:13:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2851303007/60001
3 years, 7 months ago (2017-05-22 12:00:38 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17270)
3 years, 7 months ago (2017-05-22 12:04:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2851303007/80001
3 years, 7 months ago (2017-05-22 16:23:30 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:36:35 UTC) #33
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/ac8f52de7030bad3017f20f7c...

Powered by Google App Engine
This is Rietveld 408576698