Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2851253002: Remove legacy SkPixelRef API flag from Chrome (Closed)

Created:
3 years, 7 months ago by msarett
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legacy SkPixelRef API flag from Chrome BUG=skia:6535 Review-Url: https://codereview.chromium.org/2851253002 Cr-Commit-Position: refs/heads/master@{#468635} Committed: https://chromium.googlesource.com/chromium/src/+/82ca516cd377e8956d47f29cb43215c0bd622f3d

Patch Set 1 #

Patch Set 2 : Fix Android compile errors #

Patch Set 3 : More Android fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/browser/android/thumbnail/thumbnail.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/thumbnail/thumbnail_cache.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
msarett1
3 years, 7 months ago (2017-05-01 21:54:57 UTC) #3
msarett1
Adding OWNERs for chrome/browser/android/
3 years, 7 months ago (2017-05-02 12:59:28 UTC) #8
reed1
non-owner lgtm
3 years, 7 months ago (2017-05-02 13:08:48 UTC) #11
reed1
non-owner lgtm
3 years, 7 months ago (2017-05-02 13:08:50 UTC) #12
Yaron
lgtm
3 years, 7 months ago (2017-05-02 14:18:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851253002/40001
3 years, 7 months ago (2017-05-02 15:02:46 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 15:07:35 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/82ca516cd377e8956d47f29cb432...

Powered by Google App Engine
This is Rietveld 408576698