Finish offscreen canvas using FrameSinkMangerHost.

Offscreen canvas using FrameSinkManagerHost fully.

This CL contains a number of related changes to offscreen canvas code so
that it's using FrameSinkManagerHost for everything (except surface
sequences) instead of SurfaceManager.

1. Merge OffscreenCanvasCompositorFrameSinkManager and
   OffscreenCanvasProviderImpl.
2. Offscreen canvases for a renderer are scoped to the
   OffscreenCanvasProviderImpl for that renderer.
3. OffscreenCanvasSurfaceImpls are owned by the
   OffscreenCanvasPorviderImpl instead of being StrongBinding<>s. This
   gives them a better defined life and ensures they're cleaned up with
   the rest of the renderer state.
4. Add tests for offscreen canvas code that exerecises Mojo connections.
   This should greatly improve the test coverage and better simulate
   connections from renderer to browser

BUG=664547
Review-Url: https://codereview.chromium.org/2851243002
Cr-Commit-Position: refs/heads/master@{#470359}
Committed: https://chromium.googlesource.com/chromium/src/+/c9d0c8089e8216975a893b85f078f0fb4d044daf

[kylechar, 2017-05-01 19:15:19]

Description was changed from

==========
Finish offscreen canvas using FrameSinkMangerHost.

WIP.

BUG=
==========

to

==========
Offscreen canvas using FrameSinkManagerHost fully.

This CL contains a number of related changes to offscreen canvas code so
that it's using FrameSinkManagerHost for everything.

1. Merge OffscreenCanvasCompositorFrameSinkManager and
   OffscreenCanvasProviderImpl.
2. Offscreen canvases for a renderer are scoped to the
   OffscreenCanvasProviderImpl for that renderer.
3. OffscreenCanvasSurfaceImpls are owned by the
   OffscreenCanvasPorviderImpl instead of being StrongBinding<>s. This
   gives them a better defined life and ensures they're cleaned up with
   the rest of the renderer state.
4. Add real tests for offscreen canvas code that tests Mojo connections.

BUG=664547
==========

[Fady Samuel, 2017-05-01 19:21:58]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-05-01 19:21:59]

lgtm

[kylechar, 2017-05-02 17:22:48]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 17:23:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 18:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 18:40:23]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[kylechar, 2017-05-04 13:26:33]

Description was changed from

==========
Offscreen canvas using FrameSinkManagerHost fully.

This CL contains a number of related changes to offscreen canvas code so
that it's using FrameSinkManagerHost for everything.

1. Merge OffscreenCanvasCompositorFrameSinkManager and
   OffscreenCanvasProviderImpl.
2. Offscreen canvases for a renderer are scoped to the
   OffscreenCanvasProviderImpl for that renderer.
3. OffscreenCanvasSurfaceImpls are owned by the
   OffscreenCanvasPorviderImpl instead of being StrongBinding<>s. This
   gives them a better defined life and ensures they're cleaned up with
   the rest of the renderer state.
4. Add real tests for offscreen canvas code that tests Mojo connections.

BUG=664547
==========

to

==========
Offscreen canvas using FrameSinkManagerHost fully.

This CL contains a number of related changes to offscreen canvas code so
that it's using FrameSinkManagerHost for everything (except surface
sequences) instead of SurfaceManager.

1. Merge OffscreenCanvasCompositorFrameSinkManager and
   OffscreenCanvasProviderImpl.
2. Offscreen canvases for a renderer are scoped to the
   OffscreenCanvasProviderImpl for that renderer.
3. OffscreenCanvasSurfaceImpls are owned by the
   OffscreenCanvasPorviderImpl instead of being StrongBinding<>s. This
   gives them a better defined life and ensures they're cleaned up with
   the rest of the renderer state.
4. Add tests for offscreen canvas code that exerecises Mojo connections.
   This should greatly improve the test coverage and better simulate
   connections from renderer to browser

BUG=664547
==========

[kylechar, 2017-05-04 13:27:43]

kylechar@chromium.org changed reviewers:
+ junov@chromium.org

[kylechar, 2017-05-04 13:27:44]

+junov for content/browser/renderer_host/offscreen_canvas*

There is a windows debug compile problem I'm trying to track down but I don't
think that will change the content of the CL in any appreciable way.

[kylechar, 2017-05-08 15:27:50]

junov: Think you'll get a chance to look at this today?

[Justin Novosad, 2017-05-08 15:54:33]

Sorry for the delay.
LGTM

[kylechar, 2017-05-08 20:32:12]

kylechar@chromium.org changed reviewers:
+ jochen@chromium.org

[kylechar, 2017-05-08 20:32:13]

+jochen for content/browser/BUILD.gn and content/test/BUILD.gn

[kylechar, 2017-05-08 21:17:50]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 21:19:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 21:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:25:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kylechar, 2017-05-09 13:13:37]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 13:14:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 16:06:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 16:06:24]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-09 16:23:54]

lgtm

[kylechar, 2017-05-09 16:59:05]

Thanks!

[kylechar, 2017-05-09 16:59:10]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-05-09 16:59:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2851243002/#ps120001
(title: "Add public dep.")

[commit-bot: I haz the power, 2017-05-09 16:59:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 17:06:25]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494349150321790,
"parent_rev": "f6500c14fa6592426db531673f484877cacdd651", "commit_rev":
"c9d0c8089e8216975a893b85f078f0fb4d044daf"}

[commit-bot: I haz the power, 2017-05-09 17:06:37]

Description was changed from

==========
Offscreen canvas using FrameSinkManagerHost fully.

This CL contains a number of related changes to offscreen canvas code so
that it's using FrameSinkManagerHost for everything (except surface
sequences) instead of SurfaceManager.

1. Merge OffscreenCanvasCompositorFrameSinkManager and
   OffscreenCanvasProviderImpl.
2. Offscreen canvases for a renderer are scoped to the
   OffscreenCanvasProviderImpl for that renderer.
3. OffscreenCanvasSurfaceImpls are owned by the
   OffscreenCanvasPorviderImpl instead of being StrongBinding<>s. This
   gives them a better defined life and ensures they're cleaned up with
   the rest of the renderer state.
4. Add tests for offscreen canvas code that exerecises Mojo connections.
   This should greatly improve the test coverage and better simulate
   connections from renderer to browser

BUG=664547
==========

to

==========
Offscreen canvas using FrameSinkManagerHost fully.

This CL contains a number of related changes to offscreen canvas code so
that it's using FrameSinkManagerHost for everything (except surface
sequences) instead of SurfaceManager.

1. Merge OffscreenCanvasCompositorFrameSinkManager and
   OffscreenCanvasProviderImpl.
2. Offscreen canvases for a renderer are scoped to the
   OffscreenCanvasProviderImpl for that renderer.
3. OffscreenCanvasSurfaceImpls are owned by the
   OffscreenCanvasPorviderImpl instead of being StrongBinding<>s. This
   gives them a better defined life and ensures they're cleaned up with
   the rest of the renderer state.
4. Add tests for offscreen canvas code that exerecises Mojo connections.
   This should greatly improve the test coverage and better simulate
   connections from renderer to browser

BUG=664547

Review-Url: https://codereview.chromium.org/2851243002
Cr-Commit-Position: refs/heads/master@{#470359}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9d0c8089e8216975a893b85f078...
==========

[commit-bot: I haz the power, 2017-05-09 17:06:38]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c9d0c8089e8216975a893b85f078...