DevTools: brush up audits 2 launcher UI, allow multiple audit runs, introduce landing page.

DevTools: brush up audits 2 launcher UI, allow multiple audit runs, introduce landing page.

BUG=717076, 717072
Review-Url: https://codereview.chromium.org/2851213005
Cr-Commit-Position: refs/heads/master@{#468802}
Committed: https://chromium.googlesource.com/chromium/src/+/a63f0414a0a1d530469f5ccc3c4a581d7292db4b

[pfeldman, 2017-05-01 23:44:12]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-05-02 01:27:57]

lgtm

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:68:
'click', () =>
InspectorFrontendHost.openInNewTab('https://developers.google.com/web/tools/lighthouse/'));
UI.createDocumentationLink('../lighthouse')

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:76:
this._dialog = new UI.Dialog();
Let's not recreate dialog (and settings) if there is one.

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:269:
description: 'Does this page meet the standard of a Progressive Web App'
can just inline setting here:

setting: Common.settings.createSetting('...', true)

[pfeldman, 2017-05-02 17:54:47]

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:68:
'click', () =>
InspectorFrontendHost.openInNewTab('https://developers.google.com/web/tools/lighthouse/'));
On 2017/05/02 01:27:56, dgozman wrote:
> UI.createDocumentationLink('../lighthouse')

What happens when our documentation moves?

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:76:
this._dialog = new UI.Dialog();
On 2017/05/02 01:27:56, dgozman wrote:
> Let's not recreate dialog (and settings) if there is one.

I actually think this is a good one. Let me brush up lifetimes of these objects
in a follow-up.

https://codereview.chromium.org/2851213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:269:
description: 'Does this page meet the standard of a Progressive Web App'
On 2017/05/02 01:27:56, dgozman wrote:
> can just inline setting here:
> 
> setting: Common.settings.createSetting('...', true)

Done.

[pfeldman, 2017-05-02 17:54:50]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-05-02 17:54:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2851213005/#ps20001
(title: "for landing")

[commit-bot: I haz the power, 2017-05-02 17:55:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 19:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 19:46:06]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-05-02 20:31:46]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-05-02 20:31:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2851213005/#ps40001
(title: "lcean")

[pfeldman, 2017-05-02 20:32:26]

The CQ bit was unchecked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-05-02 20:32:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-05-02 20:38:08]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-05-02 20:38:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2851213005/#ps60001
(title: "for landing")

[commit-bot: I haz the power, 2017-05-02 20:38:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 22:48:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493757488234090,
"parent_rev": "e389863c1b80cdfa819bea395fd4d5770c161ee7", "commit_rev":
"a63f0414a0a1d530469f5ccc3c4a581d7292db4b"}

[commit-bot: I haz the power, 2017-05-02 22:49:01]

Description was changed from

==========
DevTools: brush up audits 2 launcher UI, allow multiple audit runs, introduce
landing page.

BUG=717076,717072
==========

to

==========
DevTools: brush up audits 2 launcher UI, allow multiple audit runs, introduce
landing page.

BUG=717076,717072

Review-Url: https://codereview.chromium.org/2851213005
Cr-Commit-Position: refs/heads/master@{#468802}
Committed:
https://chromium.googlesource.com/chromium/src/+/a63f0414a0a1d530469f5ccc3c4a...
==========

[commit-bot: I haz the power, 2017-05-02 22:49:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a63f0414a0a1d530469f5ccc3c4a...