Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2851213004: Last set of fixed tests in preparation for enforcing that mock host resolver isn't modified in a te… (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Last set of fixed tests in preparation for enforcing that mock host resolver isn't modified in a test body. BUG=713847 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2851213004 Cr-Commit-Position: refs/heads/master@{#468510} Committed: https://chromium.googlesource.com/chromium/src/+/06d120609d01e63b439496a09945d4025b727c4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
jam
3 years, 7 months ago (2017-05-01 23:39:26 UTC) #5
Ken Rockot(use gerrit already)
On 2017/05/01 at 23:39:26, jam wrote: > LGTM with CL description nit: last set of ...
3 years, 7 months ago (2017-05-01 23:40:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851213004/1
3 years, 7 months ago (2017-05-01 23:45:45 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 00:44:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06d120609d01e63b439496a09945...

Powered by Google App Engine
This is Rietveld 408576698