content/renderer/service_worker/embedded_worker_instance_client_impl.cc - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/embedded_worker_instance_client_impl.h ('k') | content/shell/browser/layout_test/layout_test_bluetooth_fake_adapter_setter_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_instance_client_impl.cc

diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc

index 7de9b338402e5fce10715075263a612ecf70086e..424077104e1c97fff709306235cf1bd04356c2d5 100644

--- a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc

+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc

@@ -31,7 +31,8 @@ EmbeddedWorkerInstanceClientImpl::WorkerWrapper::~WorkerWrapper() = default;

// static

void EmbeddedWorkerInstanceClientImpl::Create(

- mojo::InterfaceRequest<mojom::EmbeddedWorkerInstanceClient> request) {

+ const service_manager::BindSourceInfo& source_info,

+ mojom::EmbeddedWorkerInstanceClientRequest request) {

// This won't be leaked because the lifetime will be managed internally.

new EmbeddedWorkerInstanceClientImpl(std::move(request));

}