Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/service_worker/embedded_worker_instance_client_impl.h " 5 #include "content/renderer/service_worker/embedded_worker_instance_client_impl.h "
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 13 matching lines...) Expand all
24 int devtools_agent_route_id) 24 int devtools_agent_route_id)
25 : worker_(worker), 25 : worker_(worker),
26 devtools_agent_(base::MakeUnique<EmbeddedWorkerDevToolsAgent>( 26 devtools_agent_(base::MakeUnique<EmbeddedWorkerDevToolsAgent>(
27 worker, 27 worker,
28 devtools_agent_route_id)) {} 28 devtools_agent_route_id)) {}
29 29
30 EmbeddedWorkerInstanceClientImpl::WorkerWrapper::~WorkerWrapper() = default; 30 EmbeddedWorkerInstanceClientImpl::WorkerWrapper::~WorkerWrapper() = default;
31 31
32 // static 32 // static
33 void EmbeddedWorkerInstanceClientImpl::Create( 33 void EmbeddedWorkerInstanceClientImpl::Create(
34 mojo::InterfaceRequest<mojom::EmbeddedWorkerInstanceClient> request) { 34 const service_manager::BindSourceInfo& source_info,
35 mojom::EmbeddedWorkerInstanceClientRequest request) {
35 // This won't be leaked because the lifetime will be managed internally. 36 // This won't be leaked because the lifetime will be managed internally.
36 new EmbeddedWorkerInstanceClientImpl(std::move(request)); 37 new EmbeddedWorkerInstanceClientImpl(std::move(request));
37 } 38 }
38 39
39 void EmbeddedWorkerInstanceClientImpl::WorkerContextDestroyed() { 40 void EmbeddedWorkerInstanceClientImpl::WorkerContextDestroyed() {
40 DCHECK(wrapper_); 41 DCHECK(wrapper_);
41 TRACE_EVENT0("ServiceWorker", 42 TRACE_EVENT0("ServiceWorker",
42 "EmbeddedWorkerInstanceClientImpl::WorkerContextDestroyed"); 43 "EmbeddedWorkerInstanceClientImpl::WorkerContextDestroyed");
43 44
44 if (stop_worker_time_) { 45 if (stop_worker_time_) {
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 start_data.pause_after_download_mode = 131 start_data.pause_after_download_mode =
131 params.pause_after_download 132 params.pause_after_download
132 ? blink::WebEmbeddedWorkerStartData::kPauseAfterDownload 133 ? blink::WebEmbeddedWorkerStartData::kPauseAfterDownload
133 : blink::WebEmbeddedWorkerStartData::kDontPauseAfterDownload; 134 : blink::WebEmbeddedWorkerStartData::kDontPauseAfterDownload;
134 135
135 wrapper->worker()->StartWorkerContext(start_data); 136 wrapper->worker()->StartWorkerContext(start_data);
136 return wrapper; 137 return wrapper;
137 } 138 }
138 139
139 } // namespace content 140 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698