components/password_manager/content/browser/content_password_manager_driver_factory.h - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_factory.h

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/common/nacl_service.cc ('k') | components/password_manager/content/browser/content_password_manager_driver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver_factory.h

diff --git a/components/password_manager/content/browser/content_password_manager_driver_factory.h b/components/password_manager/content/browser/content_password_manager_driver_factory.h

index 6c5de068d5defb450d8f3ce7af31b99540769353..12c3aef641e0c9169cec81e6a4e280b67c7e7d86 100644

--- a/components/password_manager/content/browser/content_password_manager_driver_factory.h

+++ b/components/password_manager/content/browser/content_password_manager_driver_factory.h

@@ -17,6 +17,7 @@

#include "components/password_manager/core/browser/password_manager.h"

#include "components/password_manager/core/browser/password_manager_driver.h"

#include "content/public/browser/web_contents_observer.h"

+#include "services/service_manager/public/cpp/bind_source_info.h"

#include "third_party/WebKit/public/platform/modules/sensitive_input_visibility/sensitive_input_visibility_service.mojom.h"

namespace content {

@@ -43,10 +44,12 @@ class ContentPasswordManagerDriverFactory

static void BindPasswordManagerDriver(

content::RenderFrameHost* render_frame_host,

+ const service_manager::BindSourceInfo& source_info,

autofill::mojom::PasswordManagerDriverRequest request);

static void BindSensitiveInputVisibilityService(

content::RenderFrameHost* render_frame_host,

+ const service_manager::BindSourceInfo& source_info,

blink::mojom::SensitiveInputVisibilityServiceRequest request);

ContentPasswordManagerDriver* GetDriverForFrame(