components/password_manager/content/browser/content_password_manager_driver_factory.cc - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_factory.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver_factory.h ('k') | components/payments/content/utility/payment_manifest_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver_factory.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver_factory.cc b/components/password_manager/content/browser/content_password_manager_driver_factory.cc

index 34ef2831dcec56179bdb4f937dc4771fd11c98be..c1dddc0ee882e600fa45eed1348f75a8ade4fba4 100644

--- a/components/password_manager/content/browser/content_password_manager_driver_factory.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver_factory.cc

@@ -76,6 +76,7 @@ ContentPasswordManagerDriverFactory::FromWebContents(

// static

void ContentPasswordManagerDriverFactory::BindPasswordManagerDriver(

content::RenderFrameHost* render_frame_host,

+ const service_manager::BindSourceInfo& source_info,

autofill::mojom::PasswordManagerDriverRequest request) {

content::WebContents* web_contents =

content::WebContents::FromRenderFrameHost(render_frame_host);

@@ -100,6 +101,7 @@ void ContentPasswordManagerDriverFactory::BindPasswordManagerDriver(

// static

void ContentPasswordManagerDriverFactory::BindSensitiveInputVisibilityService(

content::RenderFrameHost* render_frame_host,

+ const service_manager::BindSourceInfo& source_info,

blink::mojom::SensitiveInputVisibilityServiceRequest request) {

content::WebContents* web_contents =

content::WebContents::FromRenderFrameHost(render_frame_host);