Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2851163002: Handle symbol literals in closed_world2_test (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix crashes #

Total comments: 2

Patch Set 3 : Reinsert test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -24 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 1 chunk +16 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_usage.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 4 chunks +23 lines, -1 line 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-01 11:38:47 UTC) #2
Siggi Cherem (dart-lang)
lgtm, maybe keep that deleted file? https://codereview.chromium.org/2851163002/diff/20001/tests/compiler/dart2js/analyze_only_test.dart File tests/compiler/dart2js/analyze_only_test.dart (left): https://codereview.chromium.org/2851163002/diff/20001/tests/compiler/dart2js/analyze_only_test.dart#oldcode1 tests/compiler/dart2js/analyze_only_test.dart:1: // Copyright (c) ...
3 years, 7 months ago (2017-05-02 19:38:19 UTC) #3
Johnni Winther
https://codereview.chromium.org/2851163002/diff/20001/tests/compiler/dart2js/analyze_only_test.dart File tests/compiler/dart2js/analyze_only_test.dart (left): https://codereview.chromium.org/2851163002/diff/20001/tests/compiler/dart2js/analyze_only_test.dart#oldcode1 tests/compiler/dart2js/analyze_only_test.dart:1: // Copyright (c) 2012, the Dart project authors. Please ...
3 years, 7 months ago (2017-05-03 08:37:10 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-03 08:42:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6e508a8f575e9438e20c4f9592618282f28384c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698