Handle symbol literals in closed_world2_test

pkg/compiler/lib/src/common_elements.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(sigmund): rename and move to common/elements.dart
 library dart2js.type_system;
 
 import 'common/names.dart' show Identifiers, Uris;
 import 'js_backend/constant_system_javascript.dart';
 import 'elements/types.dart';
@@ skipping 119 matching lines @@
   LibraryEntity _foreignLibrary;
   LibraryEntity get foreignLibrary =>
       _foreignLibrary ??= _env.lookupLibrary(Uris.dart__foreign_helper);
 
   LibraryEntity _isolateHelperLibrary;
   LibraryEntity get isolateHelperLibrary =>
       _isolateHelperLibrary ??= _env.lookupLibrary(Uris.dart__isolate_helper);
 
   /// Reference to the internal library to lookup functions to always inline.
   LibraryEntity _internalLibrary;
-  LibraryEntity get internalLibrary =>
-      _internalLibrary ??= _env.lookupLibrary(Uris.dart__internal);
+  LibraryEntity get internalLibrary => _internalLibrary ??=
+      _env.lookupLibrary(Uris.dart__internal, required: true);
 
   /// The `NativeTypedData` class from dart:typed_data.
   ClassEntity _typedDataClass;
   ClassEntity get typedDataClass =>
       _typedDataClass ??= _findClass(typedDataLibrary, 'NativeTypedData');
 
-  /// Constructor of the `Symbol` class. This getter will ensure that `Symbol`
-  /// is resolved and lookup the constructor on demand.
-  ConstructorEntity _symbolConstructor;
-  ConstructorEntity get symbolConstructor =>
-      // TODO(johnniwinther): Kernel does not include redirecting factories
-      // so this cannot be found in kernel. Find a consistent way to handle
-      // this and similar cases.
-      _symbolConstructor ??= _findConstructor(symbolClass, '', required: false);
+  /// Constructor of the `Symbol` class in dart:internal. This getter will
+  /// ensure that `Symbol` is resolved and lookup the constructor on demand.
+  ConstructorEntity _symbolConstructorTarget;
+  ConstructorEntity get symbolConstructorTarget {
+    // TODO(johnniwinther): Kernel does not include redirecting factories
+    // so this cannot be found in kernel. Find a consistent way to handle
+    // this and similar cases.
+    return _symbolConstructorTarget ??=
+        _findConstructor(symbolImplementationClass, '');
+  }
 
   /// Whether [element] is the same as [symbolConstructor]. Used to check
   /// for the constructor without computing it until it is likely to be seen.
   // TODO(johnniwinther): Change type of [e] to [MemberEntity].
-  bool isSymbolConstructor(Entity e) => e == symbolConstructor;
+  bool isSymbolConstructor(Entity e) {
+    return e == symbolConstructorTarget ||
+        e == _findConstructor(symbolClass, '', required: false);
+  }
 
   /// The `MirrorSystem` class in dart:mirrors.
   ClassEntity _mirrorSystemClass;
   ClassEntity get mirrorSystemClass => _mirrorSystemClass ??=
       _findClass(mirrorsLibrary, 'MirrorSystem', required: false);
 
   /// Whether [element] is `MirrorClass.getName`. Used to check for the use of
   /// that static method without forcing the resolution of the `MirrorSystem`
   /// class until it is necessary.
   FunctionEntity _mirrorSystemGetNameFunction;
@@ skipping 1067 matching lines @@
   DartType getUnaliasedType(DartType type);
 
   /// Returns the [CallStructure] corresponding to calling [entity] with all
   /// arguments, both required and optional.
   CallStructure getCallStructure(FunctionEntity entity);
 
   /// Returns `true` if [member] a the synthetic getter `loadLibrary` injected
   /// on deferred libraries.
   bool isDeferredLoadLibraryGetter(MemberEntity member);
 }