Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2851093002: Drop the retargeting of accNavigate in BrowserAccessibilityWin (Closed)

Created:
3 years, 7 months ago by dougt
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop the retargeting of accNavigate in BrowserAccessibilityWin AXPlatformNode already retargets based on the start variant, so we can drop the GetTargetFromChildID call for GetPlatformNodeWin()->accNavigate. BUG=703369 Review-Url: https://codereview.chromium.org/2851093002 Cr-Commit-Position: refs/heads/master@{#468412} Committed: https://chromium.googlesource.com/chromium/src/+/851c752c37f7400ce870f46bfcaaa0d65742f15f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dougt
ptal
3 years, 7 months ago (2017-04-30 05:29:03 UTC) #6
dmazzoni
lgtm
3 years, 7 months ago (2017-05-01 16:17:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851093002/1
3 years, 7 months ago (2017-05-01 19:48:29 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:23:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/851c752c37f7400ce870f46bfcaa...

Powered by Google App Engine
This is Rietveld 408576698