Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2851063003: [Mac] Set tooltip for the app menu button (Closed)

Created:
3 years, 7 months ago by Sungmann Cho
Modified:
3 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Set tooltip for the app menu button A tooltip for the app menu button is currently not displayed, although it is defined in Toolbar.xib. In viewDidLoad: of ToolbarController, we replace the app menu button from the xib with an AppToolbarButton instance for the material design, so we need to explicitly set a tooltip for it again. BUG=716749 Review-Url: https://codereview.chromium.org/2851063003 Cr-Commit-Position: refs/heads/master@{#468366} Committed: https://chromium.googlesource.com/chromium/src/+/d2bad93f4d4f3417ce867dcd5631983cb2e36534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Sungmann Cho
Please take a look. Thanks!
3 years, 7 months ago (2017-04-29 14:20:40 UTC) #2
Robert Sesek
lgtm
3 years, 7 months ago (2017-05-01 17:44:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851063003/1
3 years, 7 months ago (2017-05-01 18:21:21 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 18:41:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2bad93f4d4f3417ce867dcd5631...

Powered by Google App Engine
This is Rietveld 408576698