Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2851063002: Revert of [turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins (Closed)

Created:
3 years, 7 months ago by danno
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins (patchset #8 id:140001 of https://codereview.chromium.org/2829093004/ ) Reason for revert: Still fails. Likely has to do with gc heap size for allocation site tests, mitigation pending... Original issue's description: > [turbofan] Reland: Avoid going through ArgumentsAdaptorTrampoline for select CSA array builtins > > This CL changes certain frequently-called Array builtins to use CodeStubArguments > rather than peek at the stack frames above array builtins to determine if options > arguments have been passed into them. > > Previous failure cannot be reproed with failing config. Flake? > > BUG=v8:1956 > LOG=N > > Review-Url: https://codereview.chromium.org/2829093004 > Cr-Commit-Position: refs/heads/master@{#44996} > Committed: https://chromium.googlesource.com/v8/v8/+/7ca381e84792b83581d0199dfae2888781785273 TBR=mvstanton@chromium.org,ishell@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1956 Review-Url: https://codereview.chromium.org/2851063002 Cr-Commit-Position: refs/heads/master@{#44997} Committed: https://chromium.googlesource.com/v8/v8/+/6953bb4012bf3b3e9e56f1fb7ba89e0294d278c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -261 lines) Patch
M src/bootstrapper.cc View 4 chunks +16 lines, -35 lines 0 comments Download
M src/builtins/builtins-array-gen.cc View 17 chunks +119 lines, -133 lines 0 comments Download
M src/builtins/builtins-definitions.h View 2 chunks +29 lines, -33 lines 0 comments Download
M src/code-factory.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 3 chunks +18 lines, -19 lines 0 comments Download
D test/mjsunit/regress/regress-709782.js View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
danno
Created Revert of [turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins
3 years, 7 months ago (2017-04-29 10:58:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851063002/1
3 years, 7 months ago (2017-04-29 10:58:44 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 10:58:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6953bb4012bf3b3e9e56f1fb7ba89e0294d...

Powered by Google App Engine
This is Rietveld 408576698