Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2851013002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, alemate+watch_chromium.org, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2851013002 Cr-Commit-Position: refs/heads/master@{#468506} Committed: https://chromium.googlesource.com/chromium/src/+/7ad715177d4c4950a979fcbaad584b75fad11853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/chromeos/drive/download_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/web_contents_forced_title.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:42:31 UTC) #6
stevenjb
lgtm
3 years, 7 months ago (2017-05-01 22:13:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851013002/1
3 years, 7 months ago (2017-05-01 23:58:20 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 00:35:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7ad715177d4c4950a979fcbaad58...

Powered by Google App Engine
This is Rietveld 408576698